-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS 19825 - Updated all operating status content-build templates #2355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icon found
Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.
What you can do
Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.
Note:
Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Noting just for reference that Limited status did change (it says no change in the description) - it is currently a yellow warning alert on Prod but we are changing to a blue info alert with this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through full QA plan
…2355) * updated all operating status content-build templates * operation_status_information.liquid was not used/imported * slim alert if no fieldOperatingStatusMoreInfo * margin and spacing
Summary
Related issue(s)
Testing done
Screenshots
VAMC System Operating status page
System operating-status page with all types of alerts
![Screenshot 2024-11-19 at 11 51 06 AM](https://github.com/user-attachments/assets/540728b3-d3fb-413a-b02e-86d8b5b4df54)VAMC Facility
VAMC facility with Limited status (no change)
VAMC fac. with Closed status (new color)
VAMC fac. with Temporary Closure status (new)
VAMC fac. with Temporary Location status (new)
VAMC fac. with Virtual Care only status (new)
VAMC fac. with Coming Soon status (new)
VAMC fac. with Facility Notice (existing - no change)
VAMC. fac with Normal Status (no change)
Vet Center
Vet Center normal status (no change)
Vet Center limited status (color/icon - info)
Vet Center closed (color/icon change - was red error - deprecated)
Vet Center Temporary facility closure (new)
Vet Center - Temporary Location (new)
Vet Center - notice (info color)
Vet Center - coming soon (new)
Vet Center Locations Pages Main Facility (not nearby)
Vet Center normal status (no change)
Vet Center limited status (color/icon - info)
Vet Center closed (color/icon change - was red error - deprecated)
Vet Center Temporary facility closure (new)
Vet Center - Temporary Location (new)
Vet Center - notice (info color)
Vet Center - coming soon (new)
What areas of the site does it impact?
VAMC system operating status pages
VAMC system pages main facility
VAMC facility pages
Vet Center pages
Vet Center locations pages
VBA pages
Acceptance criteria
VAMC system operating status pages show all types of operating statuses
VAMC system pages main facilities show types of operating status
VAMC facility pages show each type of operating status on its page
Vet Center pages show each type of operating status on its page
Vet Center locations pages show each type of operating status on its main facility
VBA pages show each type of operating status on its page
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
Check above images or release content with changes for VAMC facilities/Vet Centers/VBA and check their corresponding pages.