Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS 19825 - Updated all operating status content-build templates #2355

Merged
merged 10 commits into from
Dec 4, 2024

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Nov 15, 2024

Summary

  • Updated the operating status templates to include Temporary closure, Temporary location, Virtual care only, and Coming soon (also updates Closed to be a warning type instead of an error type and limited and notice become info types)
  • Sitewide team

Related issue(s)

Testing done

  • Manually tested VAMC system status page with all types (incl. new, changed, and same)
  • Manually tested VAMC facility pages with all types (incl. new, changed, and same)
  • Manually tested Vet Center pages with all types (incl. new, changed, and same)
  • Manually tested Vet Center listings pages with all types (incl. new, changed, and same)
  • Manually tested VBA pages with all types (incl. new, changed, and same)

Screenshots

VAMC System Operating status page

System operating-status page with all types of alerts Screenshot 2024-11-19 at 11 47 10 AM Screenshot 2024-11-19 at 11 49 39 AM Screenshot 2024-11-19 at 11 50 07 AM Screenshot 2024-11-19 at 11 50 18 AM Screenshot 2024-11-19 at 11 50 30 AM Screenshot 2024-11-19 at 11 50 40 AM Screenshot 2024-11-19 at 11 50 54 AM ![Screenshot 2024-11-19 at 11 51 06 AM](https://github.com/user-attachments/assets/540728b3-d3fb-413a-b02e-86d8b5b4df54) Screenshot 2024-11-19 at 11 51 22 AM

VAMC Facility

VAMC facility with Limited status (no change) Screenshot 2024-11-19 at 11 47 40 AM
VAMC fac. with Closed status (new color) Screenshot 2024-11-19 at 11 47 53 AM
VAMC fac. with Temporary Closure status (new) Screenshot 2024-11-19 at 11 48 06 AM
VAMC fac. with Temporary Location status (new) Screenshot 2024-11-19 at 11 48 19 AM
VAMC fac. with Virtual Care only status (new) Screenshot 2024-11-19 at 11 48 32 AM
VAMC fac. with Coming Soon status (new) Screenshot 2024-11-19 at 11 48 43 AM
VAMC fac. with Facility Notice (existing - no change) Screenshot 2024-11-19 at 11 48 56 AM
VAMC. fac with Normal Status (no change) Screenshot 2024-11-19 at 11 49 07 AM

Vet Center

Vet Center normal status (no change) Screenshot 2024-11-21 at 1 43 05 PM
Vet Center limited status (color/icon - info) Screenshot 2024-11-21 at 1 42 45 PM
Vet Center closed (color/icon change - was red error - deprecated) Screenshot 2024-11-21 at 1 42 24 PM
Vet Center Temporary facility closure (new) Screenshot 2024-11-21 at 1 41 57 PM
Vet Center - Temporary Location (new) Screenshot 2024-11-21 at 1 41 35 PM
Vet Center - notice (info color) Screenshot 2024-11-21 at 1 41 04 PM
Vet Center - coming soon (new) Screenshot 2024-11-21 at 1 40 59 PM

Vet Center Locations Pages Main Facility (not nearby)

Vet Center normal status (no change) Screenshot 2024-11-21 at 1 53 18 PM
Vet Center limited status (color/icon - info) Screenshot 2024-11-21 at 1 57 22 PM
Vet Center closed (color/icon change - was red error - deprecated) Screenshot 2024-11-21 at 1 53 37 PM
Vet Center Temporary facility closure (new) Screenshot 2024-11-21 at 1 53 48 PM
Vet Center - Temporary Location (new)
Vet Center - notice (info color) Screenshot 2024-11-21 at 1 53 56 PM
Vet Center - coming soon (new)

What areas of the site does it impact?

VAMC system operating status pages
VAMC system pages main facility
VAMC facility pages
Vet Center pages
Vet Center locations pages
VBA pages

Acceptance criteria

VAMC system operating status pages show all types of operating statuses
VAMC system pages main facilities show types of operating status
VAMC facility pages show each type of operating status on its page
Vet Center pages show each type of operating status on its page
Vet Center locations pages show each type of operating status on its main facility
VBA pages show each type of operating status on its page

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

Check above images or release content with changes for VAMC facilities/Vet Centers/VBA and check their corresponding pages.

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-19825-operating-status-update November 15, 2024 19:45 Inactive
Copy link
Collaborator

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon found

Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.

What you can do

Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.

Note:

Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon

src/site/includes/operation_status_information.liquid Outdated Show resolved Hide resolved
src/site/includes/operation_status_information.liquid Outdated Show resolved Hide resolved
src/site/includes/operation_status_information.liquid Outdated Show resolved Hide resolved
src/site/includes/operation_status_information.liquid Outdated Show resolved Hide resolved
src/site/includes/operation_status_information.liquid Outdated Show resolved Hide resolved
src/site/includes/operation_status_information.liquid Outdated Show resolved Hide resolved
src/site/includes/operation_status_information.liquid Outdated Show resolved Hide resolved
src/site/includes/operation_status_information.liquid Outdated Show resolved Hide resolved
src/site/includes/operation_status_information.liquid Outdated Show resolved Hide resolved
src/site/includes/operation_status_information.liquid Outdated Show resolved Hide resolved
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-19825-operating-status-update November 25, 2024 17:17 Inactive
Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-19825-operating-status-update November 27, 2024 16:26 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-19825-operating-status-update November 30, 2024 03:57 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-19825-operating-status-update November 30, 2024 06:06 Inactive
@eselkin eselkin requested a review from laflannery December 2, 2024 20:22
@laflannery
Copy link

Noting just for reference that Limited status did change (it says no change in the description) - it is currently a yellow warning alert on Prod but we are changing to a blue info alert with this PR

Copy link

@laflannery laflannery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through full QA plan

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-19825-operating-status-update December 3, 2024 17:33 Inactive
@eselkin eselkin deleted the VACMS-19825-operating-status-update branch December 4, 2024 01:32
timcosgrove pushed a commit that referenced this pull request Dec 4, 2024
…2355)

* updated all operating status content-build templates
* operation_status_information.liquid was not used/imported
* slim alert if no fieldOperatingStatusMoreInfo
* margin and spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants