Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Cypress from Va-internal S3. #2373

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Conversation

timcosgrove
Copy link
Contributor

@timcosgrove timcosgrove commented Dec 2, 2024

Summary

For reference, here is the vets-website implementation of this:

Testing done

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/tfc-va_hosted_cypress December 2, 2024 22:19 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/tfc-va_hosted_cypress December 2, 2024 23:39 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/tfc-va_hosted_cypress December 3, 2024 02:58 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/tfc-va_hosted_cypress December 3, 2024 05:18 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/tfc-va_hosted_cypress December 3, 2024 16:16 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/tfc-va_hosted_cypress December 3, 2024 18:27 Inactive
Copy link
Contributor

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@timcosgrove timcosgrove merged commit bfb04af into main Dec 3, 2024
27 checks passed
@timcosgrove timcosgrove deleted the tfc-va_hosted_cypress branch December 3, 2024 22:23
timcosgrove added a commit that referenced this pull request Dec 4, 2024
* Source Cypress from Va-internal S3.

* Add Cypress caching path.

* Rework and simplify yarn/cypress caching.

* Disable use of cache if for cypress container.

* Corrected syntax for if.

* Add cypress install commands.

* Restore removed caching for cypress step.

* Restore from main.

* Modifying to match vets-website setup more closely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants