Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18456 Update legacy action links to DS action links #2392

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

randimays
Copy link
Contributor

@randimays randimays commented Dec 16, 2024

Summary

Updated the remainder of old action links to <va-link-action>.

Related issue(s)

department-of-veterans-affairs/va.gov-cms#18456

Testing done / screenshots

  1. main_buttons.drupal.liquid is used for:
Health Care Region Detail Pages

Tested at /boston-health-care/contact-us

Before After
Screenshot 2024-12-17 at 11 47 29 AM Screenshot 2024-12-17 at 11 47 06 AM
Screenshot 2024-12-17 at 11 47 39 AM Screenshot 2024-12-17 at 11 47 16 AM
Health Care Region Pages

Tested at /boston-health-care/

Before After
Screenshot 2024-12-17 at 11 31 16 AM Screenshot 2024-12-17 at 11 30 33 AM
Screenshot 2024-12-17 at 11 31 29 AM Screenshot 2024-12-17 at 11 28 35 AM
Locations Listings

Tested at /boston-health-care/locations/

Before After
Screenshot 2024-12-17 at 11 23 45 AM Screenshot 2024-12-17 at 11 23 31 AM
Screenshot 2024-12-17 at 11 23 56 AM Screenshot 2024-12-17 at 11 23 40 AM
VBA Facilities

Tested at /los-angeles-va-regional-benefit-office/

Before After
Screenshot 2024-12-17 at 11 20 21 AM Screenshot 2024-12-17 at 11 20 40 AM
Screenshot 2024-12-17 at 11 20 32 AM Screenshot 2024-12-17 at 11 20 56 AM
  1. campaign_landing_page.drupal.liquid has only one change to the CTA in the video section of the page. It should be tested in this Tugboat: https://web-utwv0w9m4qeqkgwsxo9kfzxduoqdz4cj.demo.cms.va.gov/initiatives/va-health-connect/
Screenshots Screenshot 2024-12-18 at 8 57 03 AM Screenshot 2024-12-18 at 8 57 30 AM
  1. vamc_operating_status_and_alerts.drupal.liquid has a change to the "Subscribe to emergency notifications" link but this link doesn't actually work because it's trying to access CMS data that isn't there. See this Slack thread for context; ticket stub to research what happened with that link (out of scope for this ticket).

  2. action_link.drupal.liquid is used in several places, including:

R&S Detail Page (single action link)

Tested at /resources/what-your-decision-review-or-appeal-status-means/

Before After
Screenshot 2024-12-17 at 12 31 32 PM Screenshot 2024-12-17 at 12 31 13 PM
Screenshot 2024-12-17 at 12 31 40 PM Screenshot 2024-12-17 at 12 31 21 PM
R&S Detail Page (CTA list)

Tested at /resources/life-insurance-if-you-have-preexisting-conditions/

Before After
Screenshot 2024-12-17 at 12 40 36 PM Screenshot 2024-12-17 at 12 40 16 PM
Screenshot 2024-12-17 at 12 40 45 PM Screenshot 2024-12-17 at 12 40 25 PM
  1. service_location.drupal.liquid is used for health care local facilities:
Health Care Local Facilities

Tested at /south-texas-health-care/locations/audie-l-murphy-memorial-veterans-hospital/#health-care-offered-here#cancer-care

Before After
Screenshot 2024-12-17 at 1 03 06 PM Screenshot 2024-12-17 at 1 02 47 PM
Screenshot 2024-12-17 at 1 03 35 PM Screenshot 2024-12-17 at 1 03 28 PM
  1. react_widget.drupal.liquid is used in many places, but the non-CTA version with default links is difficult to find. I created one on a Tugboat and had to force it to show locally; I'm not sure exactly what the logic to display this should be. Here's the Tugboat example (under the accordions): https://web-utwv0w9m4qeqkgwsxo9kfzxduoqdz4cj.demo.cms.va.gov/resources/reimbursed-va-travel-expenses-and-mileage-rate
Screenshots Screenshot 2024-12-18 at 9 04 17 AM Screenshot 2024-12-18 at 9 04 25 AM Screenshot 2024-12-18 at 9 08 49 AM Screenshot 2024-12-18 at 9 08 55 AM

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-18456-action-links December 16, 2024 23:18 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-18456-action-links December 17, 2024 17:42 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-18456-action-links December 17, 2024 18:40 Inactive
@randimays randimays marked this pull request as ready for review December 18, 2024 15:14
@randimays randimays requested review from a team as code owners December 18, 2024 15:14
Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a nice cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants