Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VACMS-19506]Remove aria-labelledby from fullwidth banner alerts #2398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SnowboardTechie
Copy link
Contributor

Summary

  • Removes the aria-labelledby from fullwidth banner alerts
  • This was generating errors in AMP due to it creating labels without corresponding ids
  • Sitewide team
  • These fullwidth banner alerts are behind a flipper as a backup to real-time banners from the vets-api

Related issue(s)

Testing done

  • Confirmed when the flipper to use alternative banners is disabled, content build creates fullwidth-banner-alerts without the corresponding aria-labelledby attributes.

What areas of the site does it impact?

The no longer utilized VAMC fullwidthBannerAlerts

Acceptance criteria

  • aria-labelledby attribute is removed from the div that holds the content-build VAMC banners

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@SnowboardTechie SnowboardTechie self-assigned this Dec 20, 2024
@SnowboardTechie SnowboardTechie marked this pull request as ready for review December 20, 2024 16:28
@SnowboardTechie SnowboardTechie requested review from a team as code owners December 20, 2024 16:28
Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laflannery
Copy link

@SnowboardTechie you're a star, approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants