[VACMS-19406]Correct Manila Profile Page Leadership Links

[SnowboardTechie]

Summary

• Corrects the page links for Manila VA Clinic Profile Pages
• Enable a bio page for a leadership profile in the Manila VA Clinic, then while viewing said profile click the leadership link on the left side nav and find it leads to a 404 page for a non-existing system
• Process Manila VA Clinic pages for links that are pointing to this non-existent node and correct the URL's path
• Sitewide Team
• This work is not behind a flipper

Related issue(s)

• Issue: Manila: Staff Profile page: Left nav Leadership link points to incorrect path va.gov-cms#19992

Testing done

• This has been setup on Tugboat here, if that is still live, head over to https://web-8zpd9j4sobjcc5dutp67lq4xmmmsj3x2.demo.cms.va.gov/manila-va-clinic/staff-profiles/john-stelsel/ and verify the leadership link leads to the correct location.

What areas of the site does it impact?

Pages in the Manila VA Clinic

Acceptance criteria

• Leadership link in left sidenav should correctly point to the live / published Leadership list for Manila

• Existing sidenav Leadership link behavior for Lovell does not regress e.g. https://www.va.gov/lovell-federal-health-care-va/staff-profiles/robert-buckley/

  • As a VA beneficiary, left sidenav Leadership link points to https://www.va.gov/lovell-federal-health-care-va/about-us/leadership

  • [x]As a Tricare beneficiary, left sidenav link points to https://www.va.gov/lovell-federal-health-care-tricare/about-us/leadership

Quality Assurance & Testing

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Linting warnings have been addressed
• Documentation has been updated (link to documentation *if necessary)
• Screenshot of the developed feature is added
• Accessibility testing has been performed

Error Handling

• Browser console contains no warnings or errors.
• Events are being sent to the appropriate logging solution
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

• Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[va-vfs-bot]

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

[va-vfs-bot]

ESLint disabled here

[SnowboardTechie]

Disabled as the page does need to be reassigned in this build adjustment specific to Manila pages

[va-vfs-bot]

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

[va-vfs-bot]

ESLint disabled here

[SnowboardTechie]

Disabled as there is no direct FE components (labels, titles, wording) being affected, with no way for this to do more than adjust the path of a URL on the page.

[eselkin]

LGTM. Follows similar idea to process from Lovell with a few less parts.