Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Allign with PR change generated from the originating upstream project #3

Closed
wants to merge 4 commits into from
Closed

Allign with PR change generated from the originating upstream project #3

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb4a488
Allign with PR change generated from the originating upstream project
crolarlibertyva Dec 14, 2020
02fa14c
node version
crolarlibertyva Jan 30, 2021
4c04b03
revert the get in the strategy
crolarlibertyva Jan 30, 2021
aa6f17c
update version
crolarlibertyva Jan 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/passport-wsfed-saml2/samlp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ Samlp.prototype = {
try {
sig.computeSignature(SAMLRequest, { location: { reference: "//*[local-name(.)='Issuer']", action: 'after' } }); // Signature element must be located after Issuer
} catch (e) {
return callback(new Error(e));
return callback(new Error('fail to compute signature'));
}

SAMLRequest = trimXml(sig.getSignedXml());
Expand Down
3 changes: 1 addition & 2 deletions lib/passport-wsfed-saml2/strategy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,7 @@ WsFedSaml2Strategy.prototype.authenticate = function (req, opts) {
}

function executeSamlp(req) {
if (req.body && ((req.method === 'POST' && req.body.SAMLResponse) ||
(req.method === 'GET' && req.query.SAMLResponse))) {
if (req.body && req.method === 'POST' && req.body.SAMLResponse) {
crolarlibertyva marked this conversation as resolved.
Show resolved Hide resolved
// We have a response, get the user identity out of it
var loaded = function (err, ok, state) {
if (err) { return self.error(err); }
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"devDependencies": {
"chai": "2.x.x",
"chai-passport-strategy": "1.x.x",
"cheerio": "~0.19.0",
"cheerio": "^0.22.0",
"express": "~3.11.0",
"mocha": "~1.8.1",
"passport": "^0.3.2",
Expand Down