Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2103 Routine upgrades #2125

Merged
merged 8 commits into from
Nov 18, 2024
Merged

#2103 Routine upgrades #2125

merged 8 commits into from
Nov 18, 2024

Conversation

kalbfled
Copy link
Member

@kalbfled kalbfled commented Nov 15, 2024

Description

This is a routine upgrade of these top-level dependencies:

  • Updating botocore (1.35.62 -> 1.35.63)
  • Updating yarl (1.17.1 -> 1.17.2)
  • Updating boto3 (1.35.62 -> 1.35.63)

I could not upgrade pyjwt, and I opened #2131.

In pyproject.toml, I removed the "version" attribute, which seems to have been misconstrued as specifying the Poetry version. It actually specifies the project's package version, but our project is not a package.

After consultation with @k-macmillan, I also changed the specification of the project's permissible Python versions by removing the patch version. This makes API congruent with ENP, removes an annoying hindrance for team members, and makes the version consistent with what gets run on the Github test runner, which specifies "3.10".

issue #2103

How Has This Been Tested?

  • Unit tests pass
  • Regressions pass

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@kalbfled kalbfled added the patch label Nov 15, 2024
@kalbfled kalbfled self-assigned this Nov 15, 2024
@kalbfled kalbfled force-pushed the 2103-routine-upgrades branch from b718efc to 9ac0ad6 Compare November 18, 2024 14:35
@kalbfled kalbfled force-pushed the 2103-routine-upgrades branch from 00804bf to 024300f Compare November 18, 2024 16:54
@kalbfled kalbfled marked this pull request as ready for review November 18, 2024 17:28
@kalbfled kalbfled requested a review from a team as a code owner November 18, 2024 17:28
@kalbfled kalbfled merged commit 0a98c0b into main Nov 18, 2024
13 checks passed
@kalbfled kalbfled deleted the 2103-routine-upgrades branch November 18, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants