Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2184 Routine upgrades #2202

Merged
merged 6 commits into from
Dec 24, 2024
Merged

#2184 Routine upgrades #2202

merged 6 commits into from
Dec 24, 2024

Conversation

kalbfled
Copy link
Member

@kalbfled kalbfled commented Dec 24, 2024

Description

This is a PR for routine upgrades. I also made an addition to the associated issue template.

I experienced deployment errors. After some trial and error, I concluded that pinning ddtrace is the most efficient way to solve this problem, and I opened #2203 for upgrading ddtrace.

issue #2184

How Has This Been Tested?

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@kalbfled kalbfled added the patch label Dec 24, 2024
@kalbfled kalbfled self-assigned this Dec 24, 2024
@kalbfled kalbfled force-pushed the 2184-upgrades branch 2 times, most recently from 418e05c to 60eaaa5 Compare December 24, 2024 20:13
@kalbfled kalbfled marked this pull request as ready for review December 24, 2024 21:08
@kalbfled kalbfled requested a review from a team as a code owner December 24, 2024 21:08
@@ -17,7 +17,8 @@ cachelib = "*"
cachetools = "*"
celery = {extras = ["sqs"], version = "*"}
click-datetime = "*"
ddtrace = "*"
# 24 DEC 2024: Upgrading to the next minor version causes deployments to fail at the "run-deployment/deploy-api" step.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have to make a ticket for any dependencies we pin?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalbfled kalbfled merged commit 1be83d0 into main Dec 24, 2024
13 checks passed
@kalbfled kalbfled deleted the 2184-upgrades branch December 24, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants