forked from cds-snc/notification-api
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2184 Routine upgrades #2202
Merged
Merged
#2184 Routine upgrades #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalbfled
force-pushed
the
2184-upgrades
branch
from
December 24, 2024 17:45
4066a46
to
aa6ab58
Compare
kalbfled
force-pushed
the
2184-upgrades
branch
2 times, most recently
from
December 24, 2024 20:13
418e05c
to
60eaaa5
Compare
kalbfled
force-pushed
the
2184-upgrades
branch
from
December 24, 2024 20:17
60eaaa5
to
6cdc1a8
Compare
…b and cryptography.
k-macmillan
approved these changes
Dec 24, 2024
MackHalliday
approved these changes
Dec 24, 2024
@@ -17,7 +17,8 @@ cachelib = "*" | |||
cachetools = "*" | |||
celery = {extras = ["sqs"], version = "*"} | |||
click-datetime = "*" | |||
ddtrace = "*" | |||
# 24 DEC 2024: Upgrading to the next minor version causes deployments to fail at the "run-deployment/deploy-api" step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have to make a ticket for any dependencies we pin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a PR for routine upgrades. I also made an addition to the associated issue template.
I experienced deployment errors. After some trial and error, I concluded that pinning ddtrace is the most efficient way to solve this problem, and I opened #2203 for upgrading ddtrace.
issue #2184
How Has This Been Tested?
Checklist