bug\9385-Binny-AnalyticsForMismatchedContentType (#9391)

Co-authored-by: Theo Bentum <[email protected]>
department-of-veterans-affairs · Aug 16, 2024 · 30010d6 · 30010d6
1 parent abacf52
commit 30010d6
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/VAMobile/src/constants/analytics.ts b/VAMobile/src/constants/analytics.ts
@@ -6,6 +6,15 @@ import { Event, EventParams, UserAnalytic } from 'utils/analytics'
  */
 /*eslint id-length: ["error", { "max": 24 }]*/
 export const Events = {
+  vama_9385_api_cType: (endpoint: string, contentType: string): Event => {
+    return {
+      name: 'vama_9385_api_cType',
+      params: {
+        endpoint: endpoint,
+        contentType: contentType,
+      },
+    }
+  },
   vama_accordion_click: (section: string, isOpened: boolean): Event => {
     return {
       name: 'vama_accordion_click',

diff --git a/VAMobile/src/store/api/api.test.ts b/VAMobile/src/store/api/api.test.ts
@@ -99,7 +99,7 @@ context('api', () => {
     const responseBlob = new Blob(['Success'])
     const response = new Response(responseBlob, { status: 200, headers: { 'Content-Type': 'text/html' } })
     fetch.mockResolvedValue(response)
-    const result = await get<Types.UserData>('/foo')
+    const result = await post('/v0/user/logged-in')
     expect(result).toEqual(undefined)
   })
 })
diff --git a/VAMobile/src/store/api/api.ts b/VAMobile/src/store/api/api.ts
@@ -189,7 +189,11 @@ const call = async function <T>(
 
     // Guard against responses that can't be parsed as JSON
     if (!response.headers.get('Content-Type')?.startsWith('application/json')) {
-      return
+      if (endpoint === '/v0/user/logged-in') {
+        return
+      } else {
+        logAnalyticsEvent(Events.vama_9385_api_cType(endpoint, response.headers.get('Content-Type') || ''))
+      }
     }
 
     // No errors found, return the response