CU/9786-rachael-detox-messages-replace-by-text (#9787)

department-of-veterans-affairs · Oct 9, 2024 · 75d39ee · 75d39ee
1 parent 04848cf
commit 75d39ee
Show file tree

Hide file tree

Showing 12 changed files with 89 additions and 74 deletions.
diff --git a/VAMobile/e2e/tests/Messages.e2e.ts b/VAMobile/e2e/tests/Messages.e2e.ts
diff --git a/VAMobile/e2e/tests/utils.ts b/VAMobile/e2e/tests/utils.ts
@@ -79,6 +79,10 @@ export const CommonE2eIdConstants = {
   GO_TO_VA_GOV_LINK_ID: 'goToVAGovID',
   CLAIMS_HISTORY_SCROLL_ID: 'claimsHistoryID',
   NEXT_PAGE_ID: 'next-page',
+  VETERANS_CRISIS_LINE_CALL_ID: 'veteransCrisisLineCallID',
+  VETERANS_CRISIS_LINE_TTY_ID: 'veteransCrisisLineHearingLossNumberTestID',
+  VETERANS_CRISIS_LINE_TEXT_ID: 'veteransCrisisLineTextNumberTestID',
+  VETERANS_CRISIS_LINE_CHAT_ID: 'veteransCrisisLineConfidentialChatTestID',
   PREVIOUS_PAGE_ID: 'previous-page',
 }
 

diff --git a/VAMobile/src/components/CrisisLineButton.tsx b/VAMobile/src/components/CrisisLineButton.tsx
@@ -29,6 +29,7 @@ const CrisisLineButton: FC = () => {
         borderRadius: 40,
       },
     ],
+    testID: 'veteransCrisisLineID',
   }
 
   return (

diff --git a/VAMobile/src/components/FormWrapper/FormFields/FormAttachments.tsx b/VAMobile/src/components/FormWrapper/FormFields/FormAttachments.tsx
@@ -18,13 +18,21 @@ export type FormAttachmentsProps = {
   buttonLabel?: string
   /**button onPress */
   buttonPress?: () => void
+  /** optional TestID */
+  testID?: string
   /** list of current attachments */
   attachmentsList?: Array<ImagePickerResponse | DocumentPickerResponse>
 }
 
 /** A common component for form attachments, displays Attachments heading with helper link,
  * already attached items with remove option, and an optional large button. */
-const FormAttachments: FC<FormAttachmentsProps> = ({ removeOnPress, buttonLabel, buttonPress, attachmentsList }) => {
+const FormAttachments: FC<FormAttachmentsProps> = ({
+  removeOnPress,
+  buttonLabel,
+  buttonPress,
+  testID,
+  attachmentsList,
+}) => {
   const theme = useTheme()
   const { t } = useTranslation(NAMESPACE.COMMON)
   const { t: tFunction } = useTranslation()
@@ -58,6 +66,7 @@ const FormAttachments: FC<FormAttachmentsProps> = ({ removeOnPress, buttonLabel,
             label={t('remove')}
             a11yHint={t('remove.a11yHint', { content: fileName })}
             buttonType={ButtonVariants.Destructive}
+            testID={testID}
           />
         </Box>
       )
@@ -80,6 +89,7 @@ const FormAttachments: FC<FormAttachmentsProps> = ({ removeOnPress, buttonLabel,
           onPress={buttonPress}
           buttonType={ButtonVariants.Secondary}
           a11yLabel={buttonLabel}
+          testID={testID}
         />
       )}
     </Box>

diff --git a/VAMobile/src/components/Templates/FeatureLandingAndChildTemplate.tsx b/VAMobile/src/components/Templates/FeatureLandingAndChildTemplate.tsx
@@ -83,6 +83,7 @@ export const ChildTemplate: FC<ChildTemplateProps> = ({
           a11yLabel: headerButton.labelA11y,
           onPress: headerButton.onPress,
           icon: headerButton.icon,
+          testID: headerButton.testID,
         }
       : undefined,
   }

diff --git a/VAMobile/src/screens/HealthScreen/SecureMessaging/EditDraft/EditDraft.tsx b/VAMobile/src/screens/HealthScreen/SecureMessaging/EditDraft/EditDraft.tsx
@@ -448,6 +448,7 @@ function EditDraft({ navigation, route }: EditDraftProps) {
             : undefined,
         buttonPress: attachmentsList.length < theme.dimensions.maxNumMessageAttachments ? onAddFiles : undefined,
         attachmentsList,
+        testID: 'messagesAttachmentsAddFilesID',
       },
     },
     {
@@ -666,7 +667,8 @@ function EditDraft({ navigation, route }: EditDraftProps) {
       menuViewActions={isLoading ? undefined : menuViewActions}
       showCrisisLineButton={!(isLoading || hasError)}
       leftButtonTestID="editDraftCancelTestID"
-      testID="editDraftTestID">
+      testID="editDraftTestID"
+      rightButtonTestID="editDraftMoreID">
       {isLoading ? (
         <LoadingComponent text={loadingText} />
       ) : hasError ? (

diff --git a/VAMobile/src/screens/HealthScreen/SecureMessaging/FolderMessages/FolderMessages.tsx b/VAMobile/src/screens/HealthScreen/SecureMessaging/FolderMessages/FolderMessages.tsx
@@ -119,7 +119,8 @@ function FolderMessages({ route }: FolderMessagesProps) {
         navigateTo('SecureMessaging', { activeTab: 1 })
       }}
       title={title}
-      scrollViewProps={scrollViewProps}>
+      scrollViewProps={scrollViewProps}
+      backLabelTestID="foldersBackToMessagesID">
       {loadingFolderMessages ? (
         <LoadingComponent text={t('secureMessaging.messages.loading')} />
       ) : folderMessagesError ? (

diff --git a/VAMobile/src/screens/HealthScreen/SecureMessaging/ReplyMessage/ReplyMessage.tsx b/VAMobile/src/screens/HealthScreen/SecureMessaging/ReplyMessage/ReplyMessage.tsx
@@ -222,6 +222,7 @@ function ReplyMessage({ navigation, route }: ReplyMessageProps) {
             : undefined,
         buttonPress: attachmentsList.length < theme.dimensions.maxNumMessageAttachments ? onAddFiles : undefined,
         attachmentsList,
+        testID: 'messagesAttachmentsAddFilesID',
       },
     },
     {

diff --git a/VAMobile/src/screens/HealthScreen/SecureMessaging/SecureMessaging.tsx b/VAMobile/src/screens/HealthScreen/SecureMessaging/SecureMessaging.tsx
@@ -80,6 +80,7 @@ function SecureMessaging({ navigation, route }: SecureMessagingScreen) {
   const inboxLabelCount = inboxUnreadCount !== 0 ? `(${inboxUnreadCount})` : ''
   const inboxLabel = `${t('secureMessaging.inbox')} ${inboxLabelCount}`.trim()
   const controlLabels = [inboxLabel, t('secureMessaging.folders')]
+  const controlIDs = ['inboxID', 'foldersID']
   const [scrollPage, setScrollPage] = useState(1)
 
   // Resets scroll position to top whenever current page appointment list changes:
@@ -175,6 +176,7 @@ function SecureMessaging({ navigation, route }: SecureMessagingScreen) {
                 selected={secureMessagingTab}
                 a11yHints={a11yHints}
                 a11yLabels={[t('secureMessaging.inbox')]}
+                testIDs={controlIDs}
               />
             </Box>
             <CernerAlertSM />

diff --git a/...bile/src/screens/HealthScreen/SecureMessaging/StartNewMessage/Attachments/Attachments.tsx b/...bile/src/screens/HealthScreen/SecureMessaging/StartNewMessage/Attachments/Attachments.tsx
@@ -175,10 +175,12 @@ function Attachments({ navigation, route }: AttachmentsProps) {
       scrollViewRef={scrollViewRef}
       title={t('secureMessaging.startNewMessage.attachments.title')}
       leftButtonText={t('cancel')}
+      leftButtonTestID="attachmentsCancelID"
       onLeftButtonPress={navigation.goBack}
       primaryContentButtonText={
         displaySelectFile ? t('secureMessaging.attachments.selectAFile') : t('secureMessaging.startNewMessage.attach')
       }
+      primaryButtonTestID="messagesSelectAFileID"
       onPrimaryContentButtonPress={displaySelectFile ? onSelectAFile : onAttach}>
       <Box mb={theme.dimensions.contentMarginBottom} mx={theme.dimensions.gutter}>
         {!!error && (

diff --git a/VAMobile/src/screens/HealthScreen/SecureMessaging/StartNewMessage/StartNewMessage.tsx b/VAMobile/src/screens/HealthScreen/SecureMessaging/StartNewMessage/StartNewMessage.tsx
@@ -261,6 +261,7 @@ function StartNewMessage({ navigation, route }: StartNewMessageProps) {
         includeBlankPlaceholder: true,
         isRequiredField: true,
         testID: 'to field',
+        confirmTestID: 'messagePickerConfirmID',
       },
       fieldErrorMessage: t('secureMessaging.startNewMessage.to.fieldError'),
     },
@@ -274,6 +275,7 @@ function StartNewMessage({ navigation, route }: StartNewMessageProps) {
         includeBlankPlaceholder: true,
         isRequiredField: true,
         testID: 'picker',
+        confirmTestID: 'messagePickerConfirmID',
       },
       fieldErrorMessage: t('secureMessaging.startNewMessage.category.fieldError'),
     },
@@ -306,6 +308,7 @@ function StartNewMessage({ navigation, route }: StartNewMessageProps) {
             : undefined,
         buttonPress: attachmentsList.length < theme.dimensions.maxNumMessageAttachments ? onAddFiles : undefined,
         attachmentsList,
+        testID: 'messagesAttachmentsAddFilesID',
       },
     },
     {

diff --git a/VAMobile/src/screens/HealthScreen/SecureMessaging/ViewMessage/ViewMessageScreen.tsx b/VAMobile/src/screens/HealthScreen/SecureMessaging/ViewMessage/ViewMessageScreen.tsx
@@ -367,6 +367,7 @@ function ViewMessageScreen({ route, navigation }: ViewMessageScreenProps) {
             logAnalyticsEvent(Events.vama_sm_move())
             setShowModalPicker(true)
           },
+          testID: 'pickerMoveMessageID',
         }
 
   return (
@@ -375,7 +376,8 @@ function ViewMessageScreen({ route, navigation }: ViewMessageScreenProps) {
       backLabelOnPress={navigation.goBack}
       title={t('reviewMessage')}
       headerButton={headerButton}
-      testID="viewMessageTestID">
+      testID="viewMessageTestID"
+      backLabelTestID="backToMessagesID">
       {isLoading ? (
         <LoadingComponent text={loadingText} />
       ) : hasError ? (
@@ -403,6 +405,8 @@ function ViewMessageScreen({ route, navigation }: ViewMessageScreenProps) {
               confirmBtnText={'pickerLaunchBtn'}
               key={newCurrentFolderID}
               showModalByDefault={true}
+              cancelTestID="pickerMoveMessageCancelID"
+              confirmTestID="pickerMoveMessageConfirmID"
             />
           )}
           {replyExpired && (
@@ -411,6 +415,7 @@ function ViewMessageScreen({ route, navigation }: ViewMessageScreenProps) {
                 variant="warning"
                 header={t('secureMessaging.reply.youCanNoLonger')}
                 description={t('secureMessaging.reply.olderThan45Days')}
+                testID="secureMessagingOlderThan45DaysAlertID"
               />
             </Box>
           )}
-Original file line number
+Diff line change
@@ Expand Up / @@ -29,6 +29,7 @@ const CrisisLineButton: FC = () => { @@
             borderRadius: 40,
           },
         ],
+        testID: 'veteransCrisisLineID',
       }
       return (
@@ Expand Down @@