Skip to content

Commit

Permalink
label fix
Browse files Browse the repository at this point in the history
  • Loading branch information
cadibemma committed Dec 4, 2024
1 parent 9582970 commit 8536417
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ export const ChildTemplate: FC<ChildTemplateProps> = ({
const headerProps: HeaderBannerProps = {
leftButton: {
text: backLabel,
a11yLabel: backLabelA11y,
// ? t('back.a11yLabel', { screenName: backLabelA11y })
// : t('back.a11yLabel', { screenName: backLabel }),
a11yLabel: backLabelA11y
? t('back.a11yLabel', { screenName: backLabelA11y })
: t('back.a11yLabel', { screenName: backLabel }),
testID: backLabelTestID,
onPress: backLabelOnPress,
descriptiveBack: true,
Expand Down
1 change: 1 addition & 0 deletions VAMobile/src/components/Templates/HeaderBanner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ const HeaderBanner: FC<HeaderBannerProps> = ({
{leftButton?.descriptiveBack ? (
<DescriptiveBackButton
label={leftButton.text}
labelA11y={leftButton.a11yLabel}
onPress={leftButton.onPress}
focusOnButton={focus === 'Left'}
backButtonTestID={leftButton.testID}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,6 @@ function ClaimDetailsScreen({ navigation, route }: ClaimDetailsScreenProps) {
return (
<FeatureLandingTemplate
backLabel={backLabel}
backLabelA11y={t('back.a11yLabel', { screenName: backLabel })}
backLabelOnPress={navigation.goBack}
title={t('claimDetails.title')}
scrollViewProps={{ scrollViewRef }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ function ClaimsHistoryScreen({ navigation }: IClaimsHistoryScreen) {
return (
<FeatureLandingTemplate
backLabel={backLabel}
backLabelA11y={t('back.a11yLabel', { screenName: backLabel })}
backLabelOnPress={navigation.goBack}
title={title}
testID="claimsHistoryID"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ const ClaimsScreen = ({ navigation }: ClaimsScreenProps) => {
return (
<FeatureLandingTemplate
backLabel={t('benefits.title')}
backLabelA11y={t('back.a11yLabel', { screenName: t('benefits.title') })}
backLabelOnPress={navigation.goBack}
title={t('claims.title')}>
<Box mb={theme.dimensions.standardMarginBetween}>
Expand Down

0 comments on commit 8536417

Please sign in to comment.