Skip to content

Commit

Permalink
CU/9127-rachael-update-detox-PR-mapping (#9131)
Browse files Browse the repository at this point in the history
  • Loading branch information
rbontrager authored Jul 18, 2024
1 parent b238940 commit 8be2664
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/e2e_detox_mapping.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
select(contains(["ClaimsLettersScreen"]) or contains(["decisionLetters"])) += ["DecisionLetters"] |
select(contains(["DisabilityRatingsScreen"]) or contains(["disabilityRating"])) += ["DisabilityRatings", "VeteranStatusCard"] |
select(contains(["Letters"]) or contains(["letters"])) += ["VALetters"] |
select(contains(["Appointments"])) += ["Appointments", "AppointmentsExpanded"] |
select(contains(["Appointments"]) or contains(["appointments"])) += ["Appointments", "AppointmentsExpanded"] |
select(contains(["Cerner"]) or contains(["Facilities"])) += ["Cerner"] |
select(contains(["Pharmacy"]) or contains(["prescriptions"])) += ["Prescriptions"] |
select(contains(["SecureMessaging"]) or contains(["secureMessaging"])) += ["Messages"] |
Expand Down Expand Up @@ -141,8 +141,10 @@ jobs:
select(contains(["Pagination"])) += ["Appointments", "Claims", "Appeals", "AppealsExpanded", "Prescriptions", "Messages", "Payments", "VaccinesScreen"] |
select(contains(["SnackBar"])) += ["Claims", "Messages", "ContactInformation", "PersonalInformationScreen", "DirectDeposit"] |
select(contains(["VABulletList"])) += ["Appeals", "AppealsExpanded", "Claims", "Prescriptions", "Cerner", "Messages", "Onboarding", "SignIn", "SettingsScreen"] |
select(contains(["CrisisLineCta"])) += ["HomeScreen", "SignIn", "LoginScreen", "VeteransCrisisLine"] |
select(contains(["Screens.ts"]) or contains(["BasicError"]) or contains(["LoadingComponent"]) or contains(["Box"]) or contains(["HeaderTitle"]) or contains(["LargeNaveButton"])
select(contains(["CrisisLineButton"])) += ["HomeScreen", "SignIn", "LoginScreen", "VeteransCrisisLine"] |
select(contains(["ActivityButton.tsx"])) += ["HomeScreen", "Prescriptions", "Appointments", "Claims", "Appeals", "DecisionLetters"] |
select(contains(["LinkRow.tsx"])) += ["HomeScreen"] |
select(contains(["Screens.ts"]) or contains(["BasicError"]) or contains(["LoadingComponent"]) or contains(["Box"]) or contains(["HeaderTitle"]) or contains(["LargeNavButton"])
or contains(["TextArea"]) or contains(["TextLines"]) or contains(["TextView"]) or contains(["backButtonLabels"]) or contains(["common.ts"])) +=
["AvailabilityFramework", "Cerner", "ContactInformation", "VALetters", "LoginScreen", "Onboarding", "ProfileScreen", "PushNotifications", "SettingsScreen", "SignIn", "VaccineRecords", "Claims", "Appeals", "AppealsExpanded", "DisabilityRatings", "Appointments", "AppointmentsExpanded", "Prescriptions", "Messages", "MilitaryInformation", "HomeScreen", "VeteransCrisisLine", "VeteranStatusCard", "DirectDeposit", "Payments", "PersonalInformationScreen"]
| unique ')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ The following must be done for all new feature detox work no matter whether you
- Ensure the new/updating script provides artifacts (where necessary) for success and failure
- Ensure that the new test has been added to the array/dictionary in the Navigation.e2e and AvailabilityFramework.e2e tests (if needed). How to add new tests can be found [here](/docs/QA/Automation/AddingNewFeatures)
- Ensure that the test is named for the screen/feature its automating ('Prescriptions', 'HomeScreen', etc.) and that the test has been placed in the e2e folder.
- Ensure that e2e_detox_mapping.yml has been updated to account for any added/deleted files

### Updating Detox tests for non feature work

Detox is currently running on a per PR basis and is running any tests that might be affected with the code change. The following must be done if any of the detox tests fail:

- If the failing detox test is relevant to the code changes: Update any parts of the detox that were affected by the code change and repush the PR. This will cause the test to rerun.
- Update any parts of the detox that were affected by the code change and repush the PR. This will cause the test to rerun.
- If you want to check to see if the detox test works before pushing the PR you can either run the test locally or run the test in github actions using the workflow_dispatch trigger
- If the failing detox test is not relevant to the code changes: Create a ticket and specify what files were changed and what detox test was run in the description. This will allow whoever picks it up to
easily fix the detox mapping.
- Ensure that e2e_detox_mapping.yml has been updated to account for any added/deleted files in the PR

### General Best Practices
- Tests usually follow the same initial format where you import the necessary variables, have a dictionary of any constants, and run a beforeAll statement that navigates to the specific feature in the app
Expand Down

0 comments on commit 8be2664

Please sign in to comment.