v2.43.0

.github/ISSUE_TEMPLATE/feature-request.yml

@@ -92,9 +92,9 @@ body:
 - type: input
   id: duedate
   attributes:
-    label: 12.) What is your ideal due date for this change request? 
+    label: 12.) Is there a hard deadline associated with this request? 
     description: 
-    placeholder: MM/DD/YYYY or Quarter 
+    placeholder: MM/DD/YYYY 
   validations:
     required: true    
 

.github/ISSUE_TEMPLATE/release_ticket.md

@@ -3,7 +3,7 @@ name: Release Review Template
 about: Template for requesting a production release for VA mobile app
 title: "{{ env.releaseDate }} Release Sign-Off: {{ env.versionNumber }}"
 labels: release
-assignees: timwright12, chrisj-usds, dumathane, rachelhanster, SarahHuber-AdHoc, DonMcCaugheyUSDS, TKDickson
+assignees: timwright12, chrisj-usds, dumathane, SarahHuber-AdHoc, DonMcCaugheyUSDS, TKDickson
 
 ---
 

.github/workflows/app_store_checks_apple.yml

@@ -0,0 +1,68 @@
+# workflow to check that PR does not break any Apple App Store max file or max character limits
+name: "App Store requirement checks"
+
+on:
+  pull_request:
+    branches:
+      - main
+      - develop
+      - 'release/v**'
+    paths:
+      - "VAMobile/ios/fastlane/metadata/en-US/**"
+      - "VAMobile/ios/fastlane/screenshots/**"
+
+jobs:
+  check_ios_ipad_pro2_images:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 10
+      working_dir: VAMobile/ios/fastlane/screenshots/en-US
+      counting_function: find . -maxdepth 1 -name "ipadPro2*" -printf '.' | wc -m
+  check_ios_ipad_pro13_images:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 10
+      working_dir: VAMobile/ios/fastlane/screenshots/en-US
+      counting_function: find . -maxdepth 1 -name "ipadPro13*" -printf '.' | wc -m
+  check_ios_ipad_pro129_images:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 10
+      working_dir: VAMobile/ios/fastlane/screenshots/en-US
+      counting_function: find . -maxdepth 1 -name "ipadPro12*" -printf '.' | wc -m
+  check_ios_iphone55_images:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 10
+      working_dir: VAMobile/ios/fastlane/screenshots/en-US
+      counting_function: find . -maxdepth 1 -name "phone5*" -printf '.' | wc -m
+  check_ios_iphone67_images:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 10
+      working_dir: VAMobile/ios/fastlane/screenshots/en-US
+      counting_function: find . -maxdepth 1 -name "iphone6*" -printf '.' | wc -m
+  check_ios_description:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 4000
+      working_dir: VAMobile/ios/fastlane/metadata/en-US
+      counting_function: wc -c description.txt | awk '{print $1}'
+  check_ios_release_notes:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 4000
+      working_dir: VAMobile/ios/fastlane/metadata/en-US
+      counting_function: wc -c release_notes.txt | awk '{print $1}'
+  check_ios_keyword:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 1000
+      working_dir: VAMobile/ios/fastlane/metadata/en-US
+      counting_function: wc -c keywords.txt | awk '{print $1}'
+  check_ios_title:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 50
+      working_dir: VAMobile/ios/fastlane/metadata/en-US
+      counting_function: wc -c title.txt | awk '{print $1}'

.github/workflows/app_store_checks_google.yml

@@ -0,0 +1,49 @@
+# workflow to check that PR does not break any Googke Play Store max file or max character limits
+name: "App Store requirement checks"
+
+on:
+  pull_request:
+    branches:
+      - main
+      - develop
+      - 'release/v**'
+    paths:
+      - "VAMobile/android/fastlane/metadata/android/en-US/**"
+
+jobs:
+  check_max_android_phone_screenshots:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 8
+      working_dir: VAMobile/android/fastlane/metadata/android/en-US/images/phoneScreenshots
+      counting_function: ls | wc -l
+  check_max_android_seven_inch_screenshots:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 8
+      working_dir: VAMobile/android/fastlane/metadata/android/en-US/images/sevenInchScreenshots
+      counting_function: ls | wc -l
+  check_android_long_description:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 4000
+      working_dir: VAMobile/android/fastlane/metadata/android/en-US
+      counting_function: wc -c full-description.txt | awk '{print $1}'
+  check_android_short_description:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 80
+      working_dir: VAMobile/android/fastlane/metadata/android/en-US
+      counting_function: wc -c short-description.txt | awk '{print $1}'
+  check_android_change_log:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 500
+      working_dir: VAMobile/android/fastlane/metadata/android/en-US/changelogs
+      counting_function: wc -c default.txt | awk '{print $1}'
+  check_android_release_name:
+    uses: ./.github/workflows/check_max_size.yml
+    with:
+      max_size: 50
+      working_dir: VAMobile/android/fastlane/metadata/android/en-US
+      counting_function: wc -c title.txt | awk '{print $1}'

.github/workflows/check_max_size.yml

@@ -0,0 +1,25 @@
+on:
+  workflow_call:
+    inputs:
+      working_dir:
+        required: true
+        type: string
+      max_size:
+        required: true
+        type: string
+      counting_function:
+        required: true
+        type: string
+
+jobs:
+  check_max_files:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - run: |
+          if [[ $(${{ inputs.counting_function }}) -gt ${{ inputs.max_size }} ]]
+          then
+            echo "PR exceeds app store limits of ${{ inputs.max_size }} for this check"
+            exit 1
+          fi
+        working-directory: ${{ inputs.working_dir }}

.github/workflows/code_checks.yml

@@ -53,3 +53,31 @@ jobs:
         # jest with the specified files.  The number at the end is the # of chunks we're splitting the tests into.
         # This should match the numbers of items in the matrix chunk array above
         run: bash ${GITHUB_WORKSPACE}/.github/scripts/setupTestMatrix.sh ${{ matrix.chunk }} 5
+  bundle_android:
+    runs-on: ubuntu-4-cores-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version-file: 'VAMobile/.nvmrc'
+      - name: Install dependencies
+        uses: nick-fields/retry@v2
+        with:
+          timeout_minutes: 10
+          max_attempts: 3
+          command: cd VAMobile && yarn install --frozen-lockfile --non-interactive
+      - run: yarn bundle:android
+  bundle_ios:
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version-file: 'VAMobile/.nvmrc'
+      - name: Install dependencies
+        uses: nick-fields/retry@v2
+        with:
+          timeout_minutes: 10
+          max_attempts: 3
+          command: cd VAMobile && yarn install --frozen-lockfile --non-interactive
+      - run: yarn pods && yarn bundle:ios

.github/workflows/documentation_accessibility_checks.yml

@@ -1,7 +1,5 @@
 name: '[Documentation] Accessibility Check'
 
-# Adapted from https://docusaurus.io/docs/deployment
-
 on:
   workflow_dispatch:
   # Run on Weekdays at 9:00 AM UTC, 4AM ET, 1:00 AM PT
@@ -14,24 +12,24 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
+      - name: Setup node and restore yarn cache
+        uses: actions/setup-node@v3
+        with:
+          node-version-file: 'VAMobile/.nvmrc'
+          cache: 'yarn'
+          cache-dependency-path: 'VAMobile/yarn.lock'
       - name: Clean npm cache
         run: npm cache clean --force
       - name: Install Axe CLI globally
         run: npm install -g @axe-core/cli@latest
-      - name: Update npm 
-        run: npm install -g npm@latest
-      - uses: actions/setup-node@v3
-        with:
-          node-version-file: 'VAMobile/.nvmrc'
-          cache: yarn
-          cache-dependency-path: VAMobile/yarn.lock 
       - name: Install latest version of chromeDriver
         run: npm install -g chromedriver@latest
-      - name: Test build
+      - name: Run build to generate sitemap
         working-directory: VAMobile
         run: |
           yarn install --frozen-lockfile
           cd documentation
+          npx update-browserslist-db@latest
           yarn install --frozen-lockfile
           yarn build
       - name: Start web server
@@ -77,7 +75,7 @@ jobs:
         env:
           SLACK_API_TOKEN: ${{ secrets.SLACK_API_TOKEN }}
           channel_name: va-mobile-build-alerts
-          message: 'Accessibility issues detected. Please review and fix. Build started by ${{ github.actor }}: (:git: `${{ github.ref_name }}`). See :thread: or <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|workflow run> for results.'
+          message: 'Accessibility issues detected. See :thread: or <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|workflow run> for results.'
         run: |
           curl -X POST \
                -H "Authorization: Bearer $SLACK_API_TOKEN" \

.github/workflows/e2e_android.yml

@@ -226,9 +226,11 @@ jobs:
           arch: x86_64
           avd-name: Pixel_4_XL_API_28
           script: yarn e2e:android-test /e2e/tests/Navigation.e2e AvailabilityFramework.e2e ${{matrix.testsuite}}.e2e --updateSnapshot
+        continue-on-error: true
 
       - name: Run e2e tests for Android on failure
-        if: failure() && steps.run_e2e_tests_nav_AF.outcome == 'failure'
+        if: steps.run_e2e_tests_nav_AF.outcome == 'failure'
+        id: run_e2e_tests_retry
         uses: reactivecircus/android-emulator-runner@v2
         with:
           working-directory: VAMobile
@@ -239,7 +241,7 @@ jobs:
           arch: x86_64
           avd-name: Pixel_4_XL_API_28
           script: yarn e2e:android-test /e2e/tests/Navigation.e2e AvailabilityFramework.e2e ${{matrix.testsuite}}.e2e --updateSnapshot
-        
+
       - name: Upload e2e-junit
         if: failure() || success()
         uses: actions/upload-artifact@v4