bug/9548-Chika-AccessibilityLabelIsStringNameInsteadOfStringNameForPa…

…yments (#9552)
department-of-veterans-affairs · Sep 16, 2024 · f8eca0c · f8eca0c
1 parent 0738fb7
commit f8eca0c
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/VAMobile/src/App.tsx b/VAMobile/src/App.tsx
@@ -384,7 +384,7 @@ export function AppTabs() {
         <TabNav.Screen name="HomeTab" component={HomeScreen} options={{ title: t('home.title') }} />
         <TabNav.Screen name="HealthTab" component={HealthScreen} options={{ title: t('health.title') }} />
         <TabNav.Screen name="BenefitsTab" component={BenefitsScreen} options={{ title: t('benefits.title') }} />
-        <TabNav.Screen name="PaymentsTab" component={PaymentsScreen} options={{ title: t('payments') }} />
+        <TabNav.Screen name="PaymentsTab" component={PaymentsScreen} options={{ title: t('payments.title') }} />
       </TabNav.Navigator>
     </>
   )

diff --git a/.../ClaimsScreen/ClaimDetailsScreen/ClaimStatus/ClosedClaimInfo/ClosedClaimStatusDetails.tsx b/.../ClaimsScreen/ClaimDetailsScreen/ClaimStatus/ClosedClaimInfo/ClosedClaimStatusDetails.tsx
@@ -59,7 +59,7 @@ function ClosedClaimStatusDetails({ claim, claimType, letterIsDownloadable }: Cl
       )}
 
       <TextView variant="MobileBodyBold" accessibilityRole="header">
-        {t('payments')}
+        {t('payments.title')}
       </TextView>
       <TextView>{t('claimDetails.ifyoureentitled')}</TextView>
     </TextArea>

diff --git a/VAMobile/src/screens/PaymentsScreen/DirectDepositScreen/DirectDepositScreen.tsx b/VAMobile/src/screens/PaymentsScreen/DirectDepositScreen/DirectDepositScreen.tsx
@@ -93,7 +93,7 @@ function DirectDepositScreen({ navigation }: DirectDepositScreenProps) {
 
   return (
     <FeatureLandingTemplate
-      backLabel={t('payments')}
+      backLabel={t('payments.title')}
       backLabelOnPress={navigation.goBack}
       title={t('directDeposit.title')}
       testID="DirectDepositEditAccount">

diff --git a/...een/DirectDepositScreen/HowToUpdateDirectDepositScreen/HowToUpdateDirectDepositScreen.tsx b/...een/DirectDepositScreen/HowToUpdateDirectDepositScreen/HowToUpdateDirectDepositScreen.tsx
@@ -22,7 +22,7 @@ function HowToUpdateDirectDepositScreen({ navigation }: HowToUpdateDirectDeposit
   return (
     <>
       <FeatureLandingTemplate
-        backLabel={t('payments')}
+        backLabel={t('payments.title')}
         backLabelOnPress={navigation.goBack}
         title={t('directDeposit.title')}>
         <AlertWithHaptics

diff --git a/VAMobile/src/screens/PaymentsScreen/PaymentHistory/PaymentHistoryScreen.tsx b/VAMobile/src/screens/PaymentsScreen/PaymentHistory/PaymentHistoryScreen.tsx
@@ -123,7 +123,7 @@ function PaymentHistoryScreen({ navigation }: PaymentHistoryScreenProps) {
 
   return (
     <FeatureLandingTemplate
-      backLabel={t('payments')}
+      backLabel={t('payments.title')}
       backLabelOnPress={navigation.goBack}
       title={t('history.title')}
       testID="paymentHistoryTestID">

diff --git a/VAMobile/src/screens/PaymentsScreen/PaymentsScreen.tsx b/VAMobile/src/screens/PaymentsScreen/PaymentsScreen.tsx
@@ -38,7 +38,7 @@ function PaymentsScreen({}: PaymentsScreenProps) {
   }
 
   return (
-    <CategoryLanding title={t('payments')} testID="paymentsID">
+    <CategoryLanding title={t('payments.title')} testID="paymentsID">
       <Box mb={theme.dimensions.standardMarginBetween}>
         <LargeNavButton title={t('vaPaymentHistory')} onPress={onPayments} />
         {userAuthorizedServices?.directDepositBenefits && (

diff --git a/VAMobile/src/translations/en/common.json b/VAMobile/src/translations/en/common.json
@@ -1057,7 +1057,6 @@
   "paymentDetails.title": "Details",
   "paymentIssues.body": "If there is an error with your payment, or if you have questions about your payment, please call the Veterans Help Line. We’re here Monday through Friday, 8:00 a.m. to 9:00 p.m. ET.",
   "paymentIssues.body.a11yLabel": "If there is an error with your payment, or if you have questions about your payment, please call the Veterans Help Line. We’re here Monday through Friday, 8:00 a.m. to 9:00 p.m. Eastern Time.",
-  "payments": "Payments",
   "payments.ifIAmMissingPayemt": "What if I'm missing a payment?",
   "payments.ifMyPaymentDoesNotLookRight": "What if my payment information doesn't look right?",
   "payments.loading": "Loading your payment history...",
@@ -1069,6 +1068,7 @@
   "payments.noPayments.body.2.a11yLabel": "If you think this is an error, or if you have questions about your payment history, please call the Veterans Help Line. We’re here Monday through Friday, 8:00 a.m. to 9:00 p.m. Eastern Time.",
   "payments.noPayments.title": "We don't have a record of VA payments for you",
   "payments.pickerLabel": "Select a year",
+  "payments.title": "Payments",
   "payments.viewDetails": "Review details of this payment",
   "paymentsHelp.title": "Payments help",
   "pending": "pending",