Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation - Run Detox tests for Dependabot PRs #9392

Closed
2 of 9 tasks
theodur opened this issue Aug 15, 2024 · 1 comment
Closed
2 of 9 tasks

Automation - Run Detox tests for Dependabot PRs #9392

theodur opened this issue Aug 15, 2024 · 1 comment
Assignees
Labels
global Issues for the global team QA and Release Label identifies this work is done on the QA and Release Team QA Tickets require QA work / review

Comments

@theodur
Copy link
Contributor

theodur commented Aug 15, 2024

Automation Ticket

Type of Change

  • Update existing automation
  • Add new automation functionality
  • Fix automation bug

What systems/scripts are changing?

  • Git Hub Actions
  • CircleCI
  • Fastlane
  • Bash Scripts
  • Issues Templates

What is the work being done?

Dependabot PRs don't have Detox tests run on them anymore due to recent logic changes:

The e2e_ios and e2e_android workflows should be updated to run the full suite of Detox tests on Dependabot PRs. Specifically, the logic in the find_detox_tests_to_run and output_detox_tests_to_run jobs need to be updated.

Testing considerations

What testing did you do?

The logic should be tested on an existing Dependabot PR.

What testing needs to be done by the reviewer?

Verify the logic in the workflows are updated to include Dependabot PRs.

What testing needs to be done to ensure that this work is complete in production?

N/A

Acceptability Criteria

  • Android and iOS Detox tests are run for Dependabot PRs
@theodur theodur added devops QA Tickets require QA work / review QA and Release Label identifies this work is done on the QA and Release Team and removed devops labels Aug 15, 2024
@TKDickson TKDickson added the global Issues for the global team label Sep 23, 2024
@theodur
Copy link
Contributor Author

theodur commented Nov 7, 2024

I just merged the latest changes from develop, and noticed Dependabot PRs still aren't running Detox tests.

Example PR: #10048
Example workflow run: https://github.com/department-of-veterans-affairs/va-mobile-app/actions/runs/11710146054

@theodur theodur reopened this Nov 7, 2024
@TKDickson TKDickson self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
global Issues for the global team QA and Release Label identifies this work is done on the QA and Release Team QA Tickets require QA work / review
Projects
None yet
Development

No branches or pull requests

4 participants