Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU/10055-rachael-detox-add-failed-outside-detox-test-to-testRail #10060

Open
wants to merge 76 commits into
base: develop
Choose a base branch
from

Conversation

rbontrager
Copy link
Contributor

@rbontrager rbontrager commented Oct 29, 2024

Description of Change

If the detox run fails outside of the e2e test runs, no junit.xml is created and thus nothing is put into the test run for that test. This can cause confusion if it occurs when code reviewing a PR and make people believe that something is wrong with the PR (when it isn't). We should be able to add the ability to grab all tests the user wanted to be run, compare it to what is in the current test run and put any tests that aren't there as retest with a note saying that github actions has failed. This will hopefully remove some confusion.

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@TKDickson TKDickson added FE-Changes Requested Requested changes from Eng or QA and removed FE-With QA A PR waiting for QA Activity labels Nov 21, 2024
@rbontrager rbontrager added FE-With QA A PR waiting for QA Activity and removed FE-Changes Requested Requested changes from Eng or QA labels Nov 22, 2024
@rbontrager rbontrager requested review from theodur and removed request for theodur November 22, 2024 13:27
@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Nov 26, 2024
@TKDickson TKDickson requested a review from theodur November 26, 2024 18:16
@TKDickson TKDickson requested review from a team, timwright12, alexandec, dumathane, cadibemma, Sparowhawk and DonMcCaugheyUSDS and removed request for a team December 4, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants