-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CU/10055-rachael-detox-add-failed-outside-detox-test-to-testRail #10060
Open
rbontrager
wants to merge
76
commits into
develop
Choose a base branch
from
CU/10055-rachael-detox-add-failed-outside-detox-test-to-testRail
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CU/10055-rachael-detox-add-failed-outside-detox-test-to-testRail #10060
rbontrager
wants to merge
76
commits into
develop
from
CU/10055-rachael-detox-add-failed-outside-detox-test-to-testRail
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TKDickson
added
FE-Changes Requested
Requested changes from Eng or QA
and removed
FE-With QA
A PR waiting for QA Activity
labels
Nov 21, 2024
rbontrager
added
FE-With QA
A PR waiting for QA Activity
and removed
FE-Changes Requested
Requested changes from Eng or QA
labels
Nov 22, 2024
TKDickson
approved these changes
Nov 26, 2024
github-actions
bot
added
FE-Ready to Merge
and removed
FE-With QA
A PR waiting for QA Activity
labels
Nov 26, 2024
TKDickson
requested review from
a team,
timwright12,
alexandec,
dumathane,
cadibemma,
Sparowhawk and
DonMcCaugheyUSDS
and removed request for
a team
December 4, 2024 15:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
If the detox run fails outside of the e2e test runs, no junit.xml is created and thus nothing is put into the test run for that test. This can cause confusion if it occurs when code reviewing a PR and make people believe that something is wrong with the PR (when it isn't). We should be able to add the ability to grab all tests the user wanted to be run, compare it to what is in the current test run and put any tests that aren't there as retest with a note saying that github actions has failed. This will hopefully remove some confusion.
Screenshots/Video
Testing
Reviewer Validations
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch