Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CU/10195-rachael-detox-update-android-version #10197

Merged
merged 16 commits into from
Dec 4, 2024
Merged

CU/10195-rachael-detox-update-android-version #10197

merged 16 commits into from
Dec 4, 2024

Conversation

rbontrager
Copy link
Contributor

Description of Change

Update android version

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@rbontrager rbontrager marked this pull request as ready for review November 18, 2024 16:10
@rbontrager rbontrager requested review from a team as code owners November 18, 2024 16:10
theodur
theodur reviewed Nov 18, 2024
View reviewed changes
.github/workflows/e2e_android.yml Outdated
api-level: 28
profile: pixel_6_pro
api-level: 33
profile: pixel_5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, is there a reason why you lowered this to the Pixel 5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was seeing some errors originally when running the test locally on the pixel 6 pro that I wasn't seeing on the pixel 5. It looks to be working this morning though so swapped it back to a pixel 6 pro.

@rbontrager rbontrager requested a review from theodur November 20, 2024 12:29
timwright12
timwright12 previously approved these changes Dec 3, 2024
View reviewed changes
theodur
theodur previously approved these changes Dec 3, 2024
View reviewed changes
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Dec 3, 2024
@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Dec 4, 2024
@TKDickson
Copy link
Contributor

TKDickson commented Dec 4, 2024 •
edited
Loading

Subset of Android tests - passed
All Android tests - passed

@rbontrager rbontrager merged commit 95a1326 into develop Dec 4, 2024
66 of 97 checks passed
@rbontrager rbontrager deleted the CU/10195-rachael-detox-update-android-version branch December 4, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TKDickson TKDickson TKDickson approved these changes

@timwright12 timwright12 timwright12 approved these changes

@theodur theodur theodur left review comments

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rbontrager @TKDickson @timwright12 @theodur