-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation/9687-chanel-optomization-to-automatically-push-changes-on-PR #10217
Draft
IsraelleHub
wants to merge
20
commits into
develop
Choose a base branch
from
chanel-9687-automation-update-optimization-workflow-to-automatically-push-changes-through-pr
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Automation/9687-chanel-optomization-to-automatically-push-changes-on-PR #10217
IsraelleHub
wants to merge
20
commits into
develop
from
chanel-9687-automation-update-optimization-workflow-to-automatically-push-changes-through-pr
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsraelleHub
changed the title
Automation/9687-chanel-update-optomization-to-automatically-push-changes-through-pr
Automation/9687-chanel-update-optomization-to-automatically-push-changes-through
Nov 22, 2024
IsraelleHub
changed the title
Automation/9687-chanel-update-optomization-to-automatically-push-changes-through
Automation/9687-chanel-optomization-to-automatically-push-changes-on-PR
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The current Optimaze images workflow is trying to directly push changes to the release/vx.x.x branch, which is being rejected by the protected branch settings, as indicated by this error: "remote: - Changes must be made through a pull request."
A solution will be to:
[ ] modify Optimization workflow to create a pull request (PR) for the optimized images.
This will allow the changes to go through the proper review process.
[ ] After observing the behavior for some time, we can now allow it to push changes directly to release/cx.x.x branch
Screenshots/Video
Testing
Reviewer Validations
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch