Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation/9687-chanel-optomization-to-automatically-push-changes-on-PR #10217

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

IsraelleHub
Copy link
Contributor

@IsraelleHub IsraelleHub commented Nov 19, 2024

Description of Change

The current Optimaze images workflow is trying to directly push changes to the release/vx.x.x branch, which is being rejected by the protected branch settings, as indicated by this error: "remote: - Changes must be made through a pull request."

A solution will be to:
[ ] modify Optimization workflow to create a pull request (PR) for the optimized images.
This will allow the changes to go through the proper review process.
[ ] After observing the behavior for some time, we can now allow it to push changes directly to release/cx.x.x branch

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@IsraelleHub IsraelleHub changed the title Automation/9687-chanel-update-optomization-to-automatically-push-changes-through-pr Automation/9687-chanel-update-optomization-to-automatically-push-changes-through Nov 22, 2024
@IsraelleHub IsraelleHub changed the title Automation/9687-chanel-update-optomization-to-automatically-push-changes-through Automation/9687-chanel-optomization-to-automatically-push-changes-on-PR Nov 22, 2024
@IsraelleHub IsraelleHub self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant