Feature/10030+10028 create analytics and trigger #10279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumathane
requested review from
timwright12,
alexandec,
theodur,
cadibemma,
Sparowhawk and
DonMcCaugheyUSDS
dumathane
changed the base branch from
develop
to
feature/Binny-10233-CreatePIIFilter
Base automatically changed from
feature/Binny-10233-CreatePIIFilter
to
develop
December 3, 2024 13:52
alexandec
previously approved these changes
Dec 4, 2024
VAMobile/src/constants/analytics.ts
Outdated
| }, | ||
| vama_feedback_closed: (screen: string): Event => { | ||
| return { | ||
| name: 'vama_feedback_page_exit', |
There was a problem hiding this comment.
Any reason the event name differs from the function name? Usually they'd be the same
There was a problem hiding this comment.
Because it was originally exit and was too long and i forgot to change the name lol editing now.
| const lastReviewVersion = await AsyncStorage.getItem(STORAGE_LAST_REVIEW_VERSION) | ||
|
|
||
| if (days > IN_APP_REVIEW_INTERVAL_DAYS && lastReviewVersion !== versionName) { | ||
| export const useReviewEvent = (screenView?: boolean, feedbackScreen?: string): (() => Promise<void>) => { |
There was a problem hiding this comment.
You could move these args to the reviewEvent function that this function returns. Optional but it means fewer code changes overall. Also consider renaming screenView to isScreenView since it's a boolean
| const reviewEvent = async () => { | ||
| if (!featureEnabled('inAppReview') && !featureEnabled('inAppFeedback')) return | ||
| //Checked for feedbackScreen triggers first. | ||
| if (featureEnabled('inAppFeedback') && feedbackScreen) { |
There was a problem hiding this comment.
Consider moving this feedback part to a separate function since it feels like a distinct piece of code (optional)
alexandec
approved these changes
Dec 4, 2024
rbontrager
approved these changes
Dec 10, 2024
github-actions
bot
added
FE-Ready to Merge
and removed
FE-With QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Screenshots/Video
Testing
Reviewer Validations
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch