Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CU/9946-rachael-detox-add-comments-to-personalInformationScreen #10308

Merged
merged 3 commits into from
Dec 4, 2024
Merged

CU/9946-rachael-detox-add-comments-to-personalInformationScreen #10308

merged 3 commits into from
Dec 4, 2024

Conversation

rbontrager
Copy link
Contributor

Description of Change

Add comments to the personalInformationScreen detox test

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@rbontrager rbontrager requested review from a team as code owners December 4, 2024 13:32
timwright12
timwright12 previously approved these changes Dec 4, 2024
View reviewed changes
TKDickson
TKDickson reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@TKDickson TKDickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would add an explanation for why certain checks are Android-only

@rbontrager rbontrager requested a review from TKDickson December 4, 2024 15:40
@rbontrager rbontrager merged commit 792e0c7 into develop Dec 4, 2024
16 of 17 checks passed
@rbontrager rbontrager deleted the CU/9946-rachael-detox-add-comments-to-personalInformationScreen branch December 4, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TKDickson TKDickson TKDickson approved these changes

@timwright12 timwright12 timwright12 left review comments

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbontrager @timwright12 @TKDickson