Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10313-MoreIconConversionsAgain #10315

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Conversation

Sparowhawk
Copy link
Contributor

@Sparowhawk Sparowhawk commented Dec 4, 2024

Description of Change

Updated

Form Attachments(start new message, reply message screens after attaching an image) - paperclip
Collapsible message(messages in threads) - paperclip
Attachment LInk(view message screen) - paperclip
LabelTag - Info icon on prescriptions
Photo Preview - The cancel, and highlighted icons in the claims upload photo screen
Large Nav button - right arrow in circle

also updated some tests to no longer use paperclip when the code doesn't use it in those spots. This will be more important for the next pr that should remove paperclip all together.

Screenshots/Video

Screenshot 2024-12-04 at 12 08 43 PM Screenshot 2024-12-04 at 12 19 55 PM Screenshot 2024-12-04 at 12 22 36 PM Screenshot 2024-12-04 at 12 25 59 PM Screenshot 2024-12-04 at 12 27 21 PM Screenshot 2024-12-04 at 12 45 31 PM Screenshot 2024-12-04 at 12 45 35 PM

Testing

yarn test

  • Tested on iOS
  • Tested on Android

Reviewer Validations

Pass VQA with Lauren and migrate over to icon design system component, tests still pass

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@Sparowhawk Sparowhawk requested review from a team as code owners December 4, 2024 18:47
@Sparowhawk Sparowhawk changed the title updated 10313-MoreIconConversionsAgain Dec 4, 2024
alexandec
alexandec previously approved these changes Dec 11, 2024
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Dec 11, 2024
@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Dec 12, 2024
@Sparowhawk Sparowhawk merged commit 608bef9 into develop Dec 12, 2024
75 of 81 checks passed
@Sparowhawk Sparowhawk deleted the 10313-MoreIconConversionsAgain branch December 12, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants