-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation/10321-chanel-release-issue-assign-flagship-mobile-approver-members #10328
Merged
IsraelleHub
merged 13 commits into
develop
from
chanel-10321-bug-release-issue-tag-flagship-mobile-approver-members
Dec 16, 2024
Merged
Automation/10321-chanel-release-issue-assign-flagship-mobile-approver-members #10328
IsraelleHub
merged 13 commits into
develop
from
chanel-10321-bug-release-issue-tag-flagship-mobile-approver-members
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsraelleHub
changed the title
bug/10321-chanel-release-issue-should-tag-flagship-mobile-approver-members
Automation/10321-chanel-release-issue-assign-flagship-mobile-approver-members
Dec 5, 2024
IsraelleHub
added
devops
QA and Release
Label identifies this work is done on the QA and Release Team
labels
Dec 9, 2024
IsraelleHub
requested review from
timwright12,
alexandec,
theodur,
dumathane,
cadibemma,
Sparowhawk,
DonMcCaugheyUSDS and
narin
December 9, 2024 18:16
@IsraelleHub can you add a confirmation that the assignment in CI is working before we update this template? |
narin
approved these changes
Dec 13, 2024
…ip-mobile-approver-members
timwright12
approved these changes
Dec 16, 2024
github-actions
bot
added
FE-Ready to Merge
and removed
FE-With QA
A PR waiting for QA Activity
labels
Dec 16, 2024
IsraelleHub
deleted the
chanel-10321-bug-release-issue-tag-flagship-mobile-approver-members
branch
December 16, 2024 14:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
FE-Ready to Merge
QA and Release
Label identifies this work is done on the QA and Release Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The current release issue is not tagging member of flagship-mobile-release-approvers group. Instead it tags members og the flagship-mobile-release-admin group eventough the release_branch_issue workflow is tagging flagship-mobile-release-approvers group
Test:
Test was done by cloning the release_ticket.md file and by using a test workflow.
For the clone release_ticket.md file, The GitHub username hardcoded as assignee was : IsraelleHub because we didn't want to alert other approvers.
Test Results:
The current flagship-mobile-release-approvers group only has 3 members (narin, IsraelleHub, timwright12).
After running the test workflow, it assigned our release issue ticket with those assignee only as you see in this ticket
Screenshots/Video
Testing
Reviewer Validations
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch