Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation/10321-chanel-release-issue-assign-flagship-mobile-approver-members #10328

Conversation

IsraelleHub
Copy link
Contributor

@IsraelleHub IsraelleHub commented Dec 5, 2024

Description of Change

The current release issue is not tagging member of flagship-mobile-release-approvers group. Instead it tags members og the flagship-mobile-release-admin group eventough the release_branch_issue workflow is tagging flagship-mobile-release-approvers group

Test:

Test was done by cloning the release_ticket.md file and by using a test workflow.
For the clone release_ticket.md file, The GitHub username hardcoded as assignee was : IsraelleHub because we didn't want to alert other approvers.

Test Results:

The current flagship-mobile-release-approvers group only has 3 members (narin, IsraelleHub, timwright12).
After running the test workflow, it assigned our release issue ticket with those assignee only as you see in this ticket

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@IsraelleHub IsraelleHub self-assigned this Dec 5, 2024
@IsraelleHub IsraelleHub changed the title bug/10321-chanel-release-issue-should-tag-flagship-mobile-approver-members Automation/10321-chanel-release-issue-assign-flagship-mobile-approver-members Dec 5, 2024
@IsraelleHub IsraelleHub added devops QA and Release Label identifies this work is done on the QA and Release Team labels Dec 9, 2024
@IsraelleHub IsraelleHub marked this pull request as ready for review December 9, 2024 18:16
@IsraelleHub IsraelleHub requested a review from a team as a code owner December 9, 2024 18:16
@timwright12
Copy link
Contributor

@IsraelleHub can you add a confirmation that the assignment in CI is working before we update this template?

@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Dec 13, 2024
@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Dec 16, 2024
@IsraelleHub IsraelleHub merged commit 47bdb6a into develop Dec 16, 2024
17 checks passed
@IsraelleHub IsraelleHub deleted the chanel-10321-bug-release-issue-tag-flagship-mobile-approver-members branch December 16, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops FE-Ready to Merge QA and Release Label identifies this work is done on the QA and Release Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants