Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/9476-KeyboardNavigation #10332

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

theodur
Copy link
Contributor

@theodur theodur commented Dec 6, 2024

Description of Change

Fixes some of the physical keyboard issues seen in Android, particularly native alerts not being accessible and not being able to navigate past text inputs.

Screenshots/Video

Before

Unable to navigate past the text input fields, which causes the focus to shift to the previous screen.

Keyboard.Navigation.Before.webm

After

Able to navigate throughout the entire page without getting stuck.

Keyboard.Navigation.After.webm

Testing

Tested locally on Android.

  • Tested on iOS
  • Tested on Android

Reviewer Validations

Verify physical keyboard navigation on Android doesn't get stuck on text input fields.

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Dec 6, 2024
@TKDickson TKDickson removed the FE-With QA A PR waiting for QA Activity label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants