Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use i18n in unit tests - Payments 2 #10351

Merged
merged 2 commits into from
Dec 11, 2024
Merged

chore: use i18n in unit tests - Payments 2 #10351

merged 2 commits into from
Dec 11, 2024

Conversation

kimmccaskill-oddball
Copy link
Contributor

Description of Change

Update the unit tested noted in this issue

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@kimmccaskill-oddball kimmccaskill-oddball requested review from a team as code owners December 9, 2024 18:42
@kimmccaskill-oddball kimmccaskill-oddball changed the title chore: use i18n in unit tests chore: use i18n in unit tests - Payments Dec 9, 2024
@kimmccaskill-oddball kimmccaskill-oddball changed the title chore: use i18n in unit tests - Payments chore: use i18n in unit tests - Payments 2 Dec 9, 2024
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Dec 10, 2024
@kimmccaskill-oddball kimmccaskill-oddball merged commit 2a454e2 into develop Dec 11, 2024
29 of 31 checks passed
@kimmccaskill-oddball kimmccaskill-oddball deleted the chore/9992-Usei18InUnitTests-Payments-2 branch December 11, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theodur theodur theodur approved these changes

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-With QA A PR waiting for QA Activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimmccaskill-oddball @theodur