Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/10357-rachael-detox-add-ruby-install-to-e2e-android #10358

Merged
merged 14 commits into from
Dec 11, 2024
Merged

bug/10357-rachael-detox-add-ruby-install-to-e2e-android #10358

merged 14 commits into from
Dec 11, 2024

Conversation

rbontrager
Copy link
Contributor

@rbontrager rbontrager commented Dec 10, 2024 •
edited
Loading

Description of Change

The ruby/setup-ruby@v1 library pushed a patch where macos-12 was no longer supported. Because macos-latest is macos-12 I upgraded the matrix-e2e-android job to run on macos-13. This caused some flakiness with the api-level in our android emulator so downgraded the api level to 30 to reduce the flakiness.

Android run here

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@rbontrager rbontrager marked this pull request as ready for review December 10, 2024 20:52
@rbontrager rbontrager requested review from a team as code owners December 10, 2024 20:52
@rbontrager rbontrager linked an issue Dec 10, 2024 that may be closed by this pull request
BUG - Android Detox Tests Failing Due To Ruby #10357
Closed
5 tasks
theodur
theodur previously approved these changes Dec 10, 2024
View reviewed changes
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Dec 10, 2024
@github-actions github-actions bot removed the FE-With QA A PR waiting for QA Activity label Dec 11, 2024
@rbontrager rbontrager merged commit 96f2bb6 into develop Dec 11, 2024
47 of 49 checks passed
@rbontrager rbontrager deleted the bug/10357-rachael-detox-add-ruby-install-to-e2e-android branch December 11, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TKDickson TKDickson TKDickson approved these changes

@theodur theodur theodur left review comments

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG - Android Detox Tests Failing Due To Ruby
3 participants
@rbontrager @theodur @TKDickson