Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CU/9850 Detox ApptsExpanded ID cleanup #10359

Merged
merged 4 commits into from
Dec 11, 2024
Merged

CU/9850 Detox ApptsExpanded ID cleanup #10359

merged 4 commits into from
Dec 11, 2024

Conversation

TKDickson
Copy link
Contributor

@TKDickson TKDickson commented Dec 10, 2024 •
edited
Loading

Description of Change

The Appointments Expanded script is the last one that needs to be cleaned up. I am only able to complete part of the scope of the ticket, given other priorities this sprint, so this is just replacing strings in matchers with constants. Ticket will remain open, and I'll add a comment about what scope is remaining (have already also spoken with Rachael about it).

iOS run of AppointmentsExpanded

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@TKDickson TKDickson marked this pull request as ready for review December 11, 2024 17:43
@TKDickson TKDickson requested review from a team as code owners December 11, 2024 17:43
@TKDickson TKDickson mentioned this pull request Dec 11, 2024
Open
@TKDickson TKDickson merged commit f60e79f into develop Dec 11, 2024
37 of 69 checks passed
@TKDickson TKDickson deleted the CU/9850-detox-ApptExpanded-id-replacements branch December 11, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbontrager rbontrager rbontrager approved these changes

@timwright12 timwright12 timwright12 approved these changes

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TKDickson @timwright12 @rbontrager