Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to content style guide #10380

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Changes to content style guide #10380

merged 1 commit into from
Dec 12, 2024

Conversation

mistymg
Copy link
Contributor

@mistymg mistymg commented Dec 12, 2024

Description of Change

Changes to content style guide for clarity

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@mistymg mistymg requested a review from a team as a code owner December 12, 2024 15:17
@mistymg mistymg merged commit bc3e64d into develop Dec 12, 2024
18 checks passed
@mistymg mistymg deleted the doc-mmg-updates-to-content-style-guide branch December 12, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timwright12 timwright12 timwright12 approved these changes

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistymg @timwright12