Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/10134 - Notification Onboarding Screen Not Appearing After Reset Fix #10386

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Bug/10134 - Notification Onboarding Screen Not Appearing After Reset Fix #10386

wants to merge 1 commit into from

Conversation

matt-guest-wilcore
Copy link
Contributor

@matt-guest-wilcore matt-guest-wilcore commented Dec 13, 2024 •
edited
Loading

Description of Change

Updated Dev screen reset logic to show the notification permission screen once again as explained in this issue.

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

Verify that when we reset the onboarding screens from the Dev menu that we see the notifications screen.

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

Setting setNotificationsPreferenceScreen to true in the debugResetFir…
604bbe8 
…stTimeLogin function allows us to see the notification screen once again from the dev menu after hitting the reset first time login button.
@matt-guest-wilcore matt-guest-wilcore requested review from a team as code owners December 13, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matt-guest-wilcore