Bug/9461 - iOS - Some assistive tech can't get 'into'/'onto' screens where the only actionable items are initially offscreen #10394
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 18, 2024 14:23
…ate component which will allow keyboard access users to navigate further down a page. Previously screens that used this component didnt allow users to scroll down with keyboard access because the initial view didnt have an accessible element to navigate to, this fixes that.
…isplay null which would break the keyboard access logic. To combat this while still preserving the intent of the original code I opted to make a TextView with a zero-width space character so the TextView is still treated like an actionable item and still allows navigation of the page with keyboard access. Also, fixed formatting. Making this change allows keyboard navigation to work regardless if user has screenreader enabled or not.
matt-guest-wilcore
requested review from
timwright12,
alexandec,
theodur,
dumathane,
cadibemma,
Sparowhawk and
DonMcCaugheyUSDS
DonMcCaugheyUSDS
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Ticket
On iOS, Full Keyboard Access requires at least one visible, focusable element to reach off-screen content, unlike Android. Previously, some screens offered no immediate focusable elements, preventing keyboard navigation on iOS.
All affected screens share the same layout component, so I adjusted the accessibility properties in that component (FeatureLandingTemplate). I also tested with LargeFontSize enabled to account for the edge case mentioned in the ticket.
Here's a list of affected screens I found:
Screenshots/Video
Here's a video showing how Full Keyboard Access navigation looks with the new changes.
PR.video.for.9461.mp4
Testing
Reviewer Validations
Should be able to navigate to actionable content with keyboard navigation only, no matter if it's initially onscreen or not
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch