feature/8942-ClaimFilesSegment #9066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe, doc type and received date.
Sparowhawk
requested review from
timwright12,
alexandec,
theodur,
dumathane and
cadibemma
Sparowhawk
changed the title
alexandec
previously approved these changes
Jul 15, 2024
github-actions
bot
added
FE-With QA
alexandec
reviewed
Jul 15, 2024
VAMobile/src/screens/BenefitsScreen/ClaimsScreen/ClaimDetailsScreen/ClaimDetailsScreen.test.tsx
Show resolved
Hide resolved
alexandec
previously approved these changes
Jul 22, 2024
alexandec
previously approved these changes
Jul 23, 2024
| @@ -16,23 +16,41 @@ function ClaimFiles({ claim }: ClaimFilesProps) { | |||
| const { t } = useTranslation(NAMESPACE.COMMON) | |||
| const theme = useTheme() | |||
| const { attributes } = claim | |||
| const documents = attributes.eventsTimeline.filter((event) => event.filename && event.filename.length > 0) | |||
| const events = attributes.eventsTimeline.filter( | |||
| (event) => (event.filename && event.filename.length > 0) || (event.documents && event.documents.length > 0), | |||
There was a problem hiding this comment.
Optionally could simplify these checks like
(event.filename?.length || event.documents?.length)
| if (document.filename) { | ||
| const textLines: TextLine[] = [{ text: document.filename, variant: 'MobileBodyBold' }] | ||
| if (document.fileType) { | ||
| textLines.push({ text: t('appointmentList.requestType', { type: document.fileType }) }) |
There was a problem hiding this comment.
Optionally could simplify all these to one-liners like
document.fileType && textLines.push({ text: t('appointmentList.requestType', { type: document.fileType }) })
| if (document.uploadDate) { | ||
| textLines.push({ text: t('appointmentList.received', { date: document.uploadDate }) }) | ||
| } | ||
| items.push({ textLines: textLines }) |
There was a problem hiding this comment.
Could use shorthand here
alexandec
previously approved these changes
Jul 24, 2024
rbontrager
previously approved these changes
Jul 29, 2024
github-actions
bot
added
FE-Ready to Merge
and removed
FE-With QA
rbontrager
approved these changes
Jul 29, 2024
dumathane
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Created Files layout and segmented controller title change from details to files. Also created unit tests. This is behind the feature flag. See slack thread for VQA
Screenshots/Video
Testing
yarn test
Reviewer Validations
Use a row component to represent each file associated with claim
Within the row component, display these additional fields associated with each file:
Filename
Request type
Document type
Received
VQA Misty / Lauren
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch