Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/9189-Chika-InfiniteReattemptsOnProfileScreenForAuthorizedServicesError #9310

Merged
merged 2 commits into from
Aug 16, 2024
Merged

bug/9189-Chika-InfiniteReattemptsOnProfileScreenForAuthorizedServicesError #9310

merged 2 commits into from
Aug 16, 2024

Conversation

cadibemma
Copy link
Contributor

Description of Change

When the v0/authorized-services call fails, the user is logged into the app and presented with error messages on most screens.

On the Profile screen, however, we repeatedly spam-call the authorized services endpoint, for as long as the user stays on the screen. Multiple calls per millisecond, with corresponding changes in the UI and repeated/endless haptics.

Screenshots/Video

Before / After:

  

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@cadibemma cadibemma requested review from a team as code owners August 9, 2024 19:19
@dumathane dumathane added FE-With QA A PR waiting for QA Activity and removed FE-Needs Review labels Aug 14, 2024
TKDickson
TKDickson approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@TKDickson TKDickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for merge to develop

@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Aug 15, 2024
@cadibemma cadibemma merged commit c055011 into develop Aug 16, 2024
59 of 74 checks passed
@cadibemma cadibemma deleted the 9189-infinite-reattempts-of-authorized-services-on-profile-screen-when-call-fail branch August 16, 2024 15:40
@TKDickson TKDickson mentioned this pull request Sep 19, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TKDickson TKDickson TKDickson approved these changes

@dumathane dumathane dumathane approved these changes

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cadibemma @dumathane @TKDickson