Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9321-Chika-ImplementCopyChangesFromTicket9299 #9331

Merged
merged 8 commits into from
Aug 15, 2024
Merged

9321-Chika-ImplementCopyChangesFromTicket9299 #9331

merged 8 commits into from
Aug 15, 2024

Conversation

cadibemma
Copy link
Contributor

@cadibemma cadibemma commented Aug 12, 2024 •
edited
Loading

Description of Change

Add CategoryLandingAlert component to display when one of the following pieces of data can't be displayed due to issue:

  • Nametag
  • Disability Rating
  • Compensation

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@cadibemma cadibemma requested review from a team as code owners August 12, 2024 20:39
theodur
theodur previously approved these changes Aug 13, 2024
View reviewed changes
@github-actions github-actions bot added FE-With QA A PR waiting for QA Activity and removed FE-Needs Review labels Aug 13, 2024
@theodur theodur added FE-Changes Requested Requested changes from Eng or QA FE-With QA A PR waiting for QA Activity and removed FE-With QA A PR waiting for QA Activity FE-Changes Requested Requested changes from Eng or QA labels Aug 13, 2024
theodur
theodur reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@theodur theodur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be useful to add a unit test for this

@TKDickson TKDickson added FE-Changes Requested Requested changes from Eng or QA and removed FE-With QA A PR waiting for QA Activity labels Aug 13, 2024
@TKDickson
Copy link
Contributor

Sending back for the logic change in teh ticket

@cadibemma cadibemma added FE-With QA A PR waiting for QA Activity and removed FE-Changes Requested Requested changes from Eng or QA labels Aug 15, 2024
@cadibemma cadibemma requested review from theodur August 15, 2024 02:09
TKDickson
TKDickson approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@TKDickson TKDickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved to merge to develop

@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Aug 15, 2024
@cadibemma cadibemma merged commit abacf52 into develop Aug 15, 2024
35 of 36 checks passed
@cadibemma cadibemma deleted the 9321-implement-copy-changes-from-9299 branch August 15, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TKDickson TKDickson TKDickson approved these changes

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur

Assignees
No one assigned
Labels
FE-Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cadibemma @TKDickson @theodur