feature/7158-Binny-InAppReviewFeatureFlagForDetox #9342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumathane
requested review from
timwright12,
alexandec,
theodur,
cadibemma and
Sparowhawk
alexandec
previously approved these changes
Aug 13, 2024
VAMobile/src/utils/inAppReviews.tsx
Outdated
| const lastReviewVersion = await AsyncStorage.getItem(STORAGE_LAST_REVIEW_VERSION) | ||
|
|
||
| if (days > IN_APP_REVIEW_INTERVAL_DAYS && lastReviewVersion !== versionName) { | ||
| if (featureEnabled('inAppReview')) { |
There was a problem hiding this comment.
Instead of indenting all this under the conditional, consider doing
if (!featureEnabled('inAppReview')) return
at the top
| @@ -402,6 +402,7 @@ export async function verifyNonUSorMilitaryAddresses(addressID: string, addressT | |||
| }) | |||
| } | |||
| beforeAll(async () => { | |||
| await toggleRemoteConfigFlag(CommonE2eIdConstants.IN_APP_REVIEW_TOGGLE_TEXT) | |||
There was a problem hiding this comment.
Can we toggle this globally for all E2E tests instead of toggling for individual sets of tests? And then remove all the calls to resetInAppReview in all E2E tests? It would really speed up the tests I think
github-actions
bot
added
FE-With QA
github-actions
bot
added
FE-Ready to Merge
and removed
FE-With QA
TKDickson
added
FE-With QA
alexandec
approved these changes
Aug 14, 2024
github-actions
bot
added
FE-With QA
TKDickson
approved these changes
Aug 15, 2024
github-actions
bot
added
FE-Ready to Merge
and removed
FE-With QA
dumathane
deleted the
feature/7158-Binny-InAppReviewFeatureFlagForDetox
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Screenshots/Video
Testing
Reviewer Validations
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch