7159-tkd-detox-faster-without-inapp-review

[TKDickson]

Description of Change

Closes #7159 .

Removing in-app review workarounds from detox makes tests easier to maintain (one 'toggle call' at the beginning, instead of inserting the reset periodically), and faster when running.

In the scripts that were updated, here's the rough improvement (it would have been better to run repeatedly and take averages, but that would have been more time spent than what's wanted/needed):

For iOS

Script	Improvement	Raw times
Appeals Expanded	44% faster	632.469 to 350.635
Appointments Expanded	33% faster	1166.146 to 780.997
Claims	20% faster	378.195 to 303.906
Contact Information	11% faster	801.335 to 712.827
Decision Letters	8% faster	237.295 to 218.783
Messages	27% faster	582.548 to 426.152
Navigation	7% faster	993.612 (with a fail) to 919.475 (all passed))

For Android
(several scripts don't run on the Android platform)

Script	Improvement	Raw times
Appeals Expanded	25% faster	752.426 to 562.813
Appointments Expanded	n/a
Claims	n/a
Contact Information	n/a
Decision Letters	13% faster	145.099 to 125.922
Messages	28% faster	803.498 to 576.556
Navigation	10% faster	1011.49 to 910.988

Screenshots/Video

iOS most passed; rest passed
Android most passed; rest passed. Except VSC which is also failing on develop

Testing

• Tested on iOS
• Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

• PR is connected to issue(s)
• Tests are included to cover this change (when possible)
• No magic strings (All string unions follow the Union -> Constant type pattern)
• No secrets or API keys are checked in
• All imports are absolute (no relative imports)
• New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

[dumathane]

Doing gods work here Therese. :-)