Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/9366-rachael-detox-fix-nightly-build #9381

Merged
merged 12 commits into from
Aug 19, 2024

Conversation

rbontrager
Copy link
Contributor

@rbontrager rbontrager commented Aug 15, 2024

Description of Change

Claims and decision letters were failing in iOS and navigation in Android. Passing iOS test case (minus those cases affected by in app review that we are removing): iOS. Passing android test cases here

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@rbontrager rbontrager marked this pull request as ready for review August 16, 2024 17:12
@rbontrager rbontrager requested review from a team as code owners August 16, 2024 17:12
@@ -28,7 +28,7 @@
"type": "ios.simulator",
"device": {
"type": "iPhone 15 Pro Max",
"os": "iOS 17.4"
"os": "iOS 17.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to include this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so there is a record. Yes I did because the detox runs are still usually getting 1 or 2 timeouts for iOS. I changed it to see if this works better. I didn't have any timeouts on the detox run I did so I'm hopeful this will remove them all together.

@rbontrager rbontrager merged commit 8b809f3 into develop Aug 19, 2024
53 of 58 checks passed
@rbontrager rbontrager deleted the bug/9366-rachael-detox-fix-nightly-build branch August 19, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants