-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug/9366-rachael-detox-fix-nightly-build #9381
bug/9366-rachael-detox-fix-nightly-build #9381
Conversation
@@ -28,7 +28,7 @@ | |||
"type": "ios.simulator", | |||
"device": { | |||
"type": "iPhone 15 Pro Max", | |||
"os": "iOS 17.4" | |||
"os": "iOS 17.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intend to include this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so there is a record. Yes I did because the detox runs are still usually getting 1 or 2 timeouts for iOS. I changed it to see if this works better. I didn't have any timeouts on the detox run I did so I'm hopeful this will remove them all together.
Description of Change
Claims and decision letters were failing in iOS and navigation in Android. Passing iOS test case (minus those cases affected by in app review that we are removing): iOS. Passing android test cases here
Screenshots/Video
Testing
Reviewer Validations
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch