feature/9164-SubmitEvidence #9394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sparowhawk
requested review from
timwright12,
alexandec,
theodur,
dumathane and
cadibemma
dumathane
reviewed
Aug 19, 2024
dumathane
reviewed
Aug 19, 2024
dumathane
reviewed
Aug 19, 2024
dumathane
reviewed
Aug 19, 2024
VAMobile/src/screens/BenefitsScreen/ClaimsScreen/ClaimDetailsScreen/ClaimDetailsScreen.tsx
Show resolved
Hide resolved
alexandec
requested changes
Aug 19, 2024
...msScreen/ClaimDetailsScreen/ClaimStatus/ClaimFileUpload/SelectFile/UploadFile/UploadFile.tsx
Show resolved
Hide resolved
|
Also noticed a conflict on the Claims E2E tests |
theodur
added
FE-Changes Requested
dumathane
reviewed
Aug 19, 2024
...msScreen/ClaimDetailsScreen/ClaimStatus/ClaimFileUpload/SelectFile/UploadFile/UploadFile.tsx
Show resolved
Hide resolved
dumathane
reviewed
Aug 19, 2024
...msScreen/ClaimDetailsScreen/ClaimStatus/ClaimFileUpload/SelectFile/UploadFile/UploadFile.tsx
Outdated
Show resolved
Hide resolved
dumathane
reviewed
Aug 19, 2024
...enefitsScreen/ClaimsScreen/ClaimDetailsScreen/ClaimStatus/ClaimFileUpload/SubmitEvidence.tsx
Outdated
Show resolved
Hide resolved
dumathane
reviewed
Aug 19, 2024
dumathane
previously approved these changes
Aug 28, 2024
dumathane
added
FE-With QA
dumathane
previously approved these changes
Sep 3, 2024
rbontrager
approved these changes
Sep 4, 2024
github-actions
bot
added
FE-Ready to Merge
and removed
FE-With QA
alexandec
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added submit evidence button to claims not in step 3 and put the workflow behind the feature flag submitEvidenceExpansion. Updated unit tests and e2e tests. Added submit evidence screen, updated workflow for file request and submit evidence to be full screen subtasks with cancels instead of back buttons and updated the copy for submit evidence scenario and allowed uploading files without an associated request
Had to update podfile as well
Screenshots/Video
Submit Evidence workflow
Testing
yarn test/detox also tested on Judy
Reviewer Validations
All
Launch as a Fullscreen Subtask
On completion/cancel, route user back to previous Child screen. So, either [Claim detail: Submit evidence] or [Claim detail: Review file request]
Submit evidence flow
Create first screen; follow copy deck and design
Make any copy updates to subsequent screens within the flow
Review File Request flow
Make any copy updates to subsequent screens within the flow
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch