Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/9386-add-claim-type-code-to-analytics #9396

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

alexandec
Copy link
Contributor

Description of Change

Add claim_type_code and is_disability_comp_claim parameters to the vama_claim_details_open event.

Screenshots/Video

Console output when viewing claim details:

logging analytics event vama_claim_details_open {"claim_id": "600236068", "claim_step": 3, "claim_step_change": "2021-05-05", "claim_submitted_date": "2021-01-01", "claim_type": "Compensation", "claim_type_code": "010LCOMP", "is_disability_comp_claim": true}

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

claim_type_code and is_disability_comp_claim parameters are added to vama_claim_details_open event

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@github-actions github-actions bot added FE-With QA A PR waiting for QA Activity and removed FE-Needs Review labels Aug 16, 2024
@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Aug 16, 2024
@dumathane dumathane merged commit 9f7c8ae into develop Aug 19, 2024
33 of 35 checks passed
@dumathane dumathane deleted the feature/9386-add-claim-type-code-to-analytics branch August 19, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants