Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CU] Update Expo to SDK 52 #600

Merged
merged 9 commits into from
Dec 5, 2024
Merged

[CU] Update Expo to SDK 52 #600

merged 9 commits into from
Dec 5, 2024

Conversation

narin
Copy link
Contributor

@narin narin commented Dec 5, 2024

Description of Change

Updated to Expo SDK 52 using the update guide found in the Changelog.

  • Ran npx expo install expo@^52.0.0 --fix and npx expo-doctor@latest to update expo and related dependencies
  • Enabled new architecture in app.json
  • Had to remove @os-team/i18next-react-native-language-detector package as it seems to be incompatible with Expo 52 / RN 0.76. Tried updating to latest, updating i18n package to latest, and tried alternative packages without luck. Decided to remove language detection and separate to separate ticket (DS - Reenable Language Detection #599) since we are only supporting English.
  • Tested on iOS/Android and alpha version in va-mobile-app

Testing Packages

  • 0.28.1-alpha.0
  • 0.28.1-alpha.1

Screenshots/Video

N/A

Testing

  • Tested on iOS
  • Tested on Android
  • Tested on Web

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

@narin narin changed the title Cu/597 narin update expo sdk 52 [CU] Update Expo to SDK 52 Dec 5, 2024
@narin narin marked this pull request as ready for review December 5, 2024 04:47
@narin narin requested a review from a team as a code owner December 5, 2024 04:47
@TimRoe
Copy link
Contributor

TimRoe commented Dec 5, 2024

Had to remove @os-team/i18next-react-native-language-detector package as it seems to be incompatible with Expo 52 / RN 0.76. Tried updating to latest, updating i18n package to latest, and tried alternative packages without luck. Decided to remove language detection and separate to separate ticket (#599) since we are only supporting English.

Not sure if flagship had anything (e.g. an epic) tracking supporting other languages, but if they do we should definitely link this ticket to it as a dependency since then all design-system-translations would fallback to using English.

Copy link
Contributor

@TimRoe TimRoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with two minor suggestions.

narin added 2 commits December 5, 2024 13:06
…nt-of-veterans-affairs/va-mobile-library into cu/597-narin-update-expo-sdk-52
@narin narin merged commit 287ed77 into main Dec 5, 2024
4 of 5 checks passed
@narin narin deleted the cu/597-narin-update-expo-sdk-52 branch December 5, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants