-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CU] Update Expo to SDK 52 #600
Conversation
…nt-of-veterans-affairs/va-mobile-library into cu/597-narin-update-expo-sdk-52
Not sure if flagship had anything (e.g. an epic) tracking supporting other languages, but if they do we should definitely link this ticket to it as a dependency since then all design-system-translations would fallback to using English. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with two minor suggestions.
…nt-of-veterans-affairs/va-mobile-library into cu/597-narin-update-expo-sdk-52
Description of Change
Updated to Expo SDK 52 using the update guide found in the Changelog.
npx expo install expo@^52.0.0 --fix
andnpx expo-doctor@latest
to update expo and related dependenciesapp.json
@os-team/i18next-react-native-language-detector
package as it seems to be incompatible with Expo 52 / RN 0.76. Tried updating to latest, updating i18n package to latest, and tried alternative packages without luck. Decided to remove language detection and separate to separate ticket (DS - Reenable Language Detection #599) since we are only supporting English.Testing Packages
Screenshots/Video
N/A
Testing
PR Checklist
Code reviewer validation:
changelog
label applied if it's to be included in the changelogPublish
If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:
main
into branchmain