Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install and use the correct node version when starting Next Build. #20132

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

timcosgrove
Copy link
Contributor

Description

Testing installing the correct node version.

Relates to #issueid. (or closes?)

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@timcosgrove timcosgrove requested a review from a team as a code owner December 18, 2024 19:18
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 19:18 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 20:09 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 20:29 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 21:30 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 19, 2024 08:58 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 20, 2024 08:47 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 21, 2024 08:45 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 22, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 23, 2024 08:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 24, 2024 08:45 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 25, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 26, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 27, 2024 08:41 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 28, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 29, 2024 08:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 30, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 31, 2024 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 1, 2025 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 2, 2025 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 3, 2025 08:41 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 4, 2025 08:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 5, 2025 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 6, 2025 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 7, 2025 08:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 8, 2025 08:34 Destroyed
Copy link

github-actions bot commented Jan 9, 2025

Checking composer.lock changes...

@timcosgrove timcosgrove force-pushed the tfc-cms_tugboat_next_build_use_correct_node branch from ab25b77 to f4f847e Compare January 9, 2025 02:24
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2025 02:24 Destroyed
Copy link

github-actions bot commented Jan 9, 2025

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 10, 2025 08:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 11, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 12, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 13, 2025 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 14, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 15, 2025 08:36 Destroyed
@va-cms-bot
Copy link
Collaborator

Cypress Accessibility Violations

/test-data-qui

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants