VACMS-19075: Reduces services to only facility

[omahane]

Description

Relates to #19075

Testing done

Manually

Screenshots

Facility field after selection

VAMC system health service after AJAX

QA steps

Setup up QA Content Publisher

• Log in as an admin
• Assign the following roles to QA Content Publisher:
  • Content creator - VAMC
  • Content publisher
• Assign the following sections to QA Content Publisher:
  • VA Boston health care
  • VA Pittsburgh health care
  • Lovell Federal health care

Create VAMC facility health services

• Log in as QA Content Publisher
• Create a VAMC Facility Health Service
• Under Section choose "VA Boston health care"
• Under Facility name choose "Jamaica Plain VA Medical Center"
• Confirm that under VAMC system health service only the following choices are available:
  • Adaptive sports at VA Boston health care
  • Bariatric surgery at VA Boston health care
  • Diabetes care at VA Boston health care
  • Neurology at VA Boston health care
  • Neurosurgery at VA Boston health care
  • Ophthalmology at VA Boston health care
  • Orthopedics at VA Boston health care
  • Otolaryngology at VA Boston health care
  • Plastic and reconstructive surgery at VA Boston health care
  • Podiatry at VA Boston health care
  • Thoracic surgery at VA Boston health care
  • Vascular surgery at VA Boston health care
• Change the Facility name choice to "Brockton VA Medical Center"
• Confirm that among the choices for VAMC system health service are the following:
  • Allergy, asthma and immunology at VA Boston health care
  • Veteran readiness and employment programs at VA Boston health care
• Confirm that the following already created services are not among the options for VAMC system health service:
  • Adaptive sports at VA Boston health care
  • Pharmacy at VA Boston health care
• Change the Facility name choice to "Monroeville VA Clinic"
• Confirm that among the choices for VAMC system health service are the following:
  • Addiction and substance use care at VA Pittsburgh health care
  • Women Veteran care at VA Pittsburgh health care
• Confirm that the following already created services are not among the options for VAMC system health service:
  • Chiropractic at VA Pittsburgh health care
  • Gastroenterology at VA Pittsburgh health care
• Change the Facility name choice to "Naval Great Lakes Burkey Mall Pharmacy | Lovell Federal health care - TRICARE"
• Confirm that among the choices for VAMC system health service are the following:
  • Addiction and substance use care at VA Lovell federal health care - TRICARE
  • Case management at VA Lovell federal health care - TRICARE
• Confirm that the following already created services are not among the options for VAMC system health service:
  • Pharmacy at VA Lovell federal health care - TRICARE
• Change the Facility name choice to "McHenry VA Clinic | Lovell Federal health care - VA"
• Confirm that among the choices for VAMC system health service are the following:
  • Advice nurse at VA Lovell federal health care - VA
  • Vascular surgery at VA Lovell federal health care - VA
• Confirm that the following already created services are not among the options for VAMC system health service:
  • Nephrology at VA Lovell federal health care - VA
  • Psychiatry at VA Lovell federal health care - VA

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[va-cms-bot]

Cypress Accessibility Violations

/test-data-quis

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
  Impact: critical
  Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: button[data-proofing-help-title="About 'Main content' field"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"

[dsasser]

Looks great!

A couple non-blocking things we could change if we were going to be doing this on (many) other fields in the future:

1. Code re-use. Some parts of the 'reduce' and 'ajax' functions could be abstracted to handle different fields in different situations. This would only be beneficial if there were an expectation that we would be doing this in many places.
2. Static caching. The '_service_names' functions that return the correct $options for a given facility/system could benefit from static caching if we thought that the editor might be making many changes to the facility/system and needed an extra boost in performance. As it is, this is not worth the effort as the queries are well structured and don't contain joins/other complex requirements.

Nice work!

[Shamiaalam]

I checked and review with @omahane, and everything works good from my side.