Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create POA Request Search Status Tabs Design #96894

Open
7 tasks
nihil2501 opened this issue Nov 12, 2024 · 8 comments
Open
7 tasks

Create POA Request Search Status Tabs Design #96894

nihil2501 opened this issue Nov 12, 2024 · 8 comments
Assignees
Labels
accredited-rep-facing Accredited Representative Facing Team engineering Engineering topics frontend

Comments

@nihil2501
Copy link
Contributor

nihil2501 commented Nov 12, 2024

Description

User Story or Problem Statement

As a representative, I want to be able to see a list of pending and completed POA requests so I know which ones will need my attention.

Implementation Details

  • react-router based navigation to update query params (e.g. status=Accepted) and reflect in the active tab
  • Pending, Completed tabs

Mockups/Designs

Blockers

Acceptance Criteria/Conditions of Satisfaction

  • a rep will see a list of Pending POA requests by default
  • a rep will see a list of POA requests that have been accepted or declined, if they view the Completed tab
  • a rep will see a message about POA requests expiration, relevant to the tab they are on

Resources

Accessibility (A11y) Testing

  • Refer to existing VA design system
  • Test with either WAVE or AXE extension
  • As you manually test, look for the following:
    • color contrast errors
    • keyboard navigation
      • When navigating with a keyboard, content should flow from left to right
    • heading order
      • Headings should be in order, so h1, then h2, h3. This is so the screen reader can let the user know the natural order of the elements in page. The WAVE tool has a headings tab that will display the order.
    • Voiceover is built in with mac, use NVDA for windows
@nihil2501 nihil2501 added accredited-rep-facing Accredited Representative Facing Team arf-eng frontend labels Nov 12, 2024
@nihil2501 nihil2501 changed the title Search UX (First Pass) Search (First Pass) Design Nov 12, 2024
@nihil2501 nihil2501 changed the title Search (First Pass) Design POA Request Search (First Pass) Design Nov 12, 2024
@nihil2501 nihil2501 changed the title POA Request Search (First Pass) Design POA Request Search (First Pass) UX Nov 12, 2024
@candilemoine
Copy link
Contributor

candilemoine commented Nov 12, 2024

@candilemoine candilemoine changed the title POA Request Search (First Pass) UX POA Request Search (First Pass - pagination and tabs) UX Nov 12, 2024
@nihil2501 nihil2501 changed the title POA Request Search (First Pass - pagination and tabs) UX POA Request Search Status Tabs Design Nov 19, 2024
@candilemoine candilemoine changed the title POA Request Search Status Tabs Design Create POA Request Search Status Tabs Design Nov 21, 2024
@eheintzelman
Copy link
Contributor

@jquispe-oddball @nihil2501 @Kate-allbee @seipeljl @candilemoine
For the tabs concept on the POA requests landing page, there is some ongoing discussion in the Figma designs of what we want that second tab to be. Should it be completed requests or All requests? Just flagging that this is an outstanding question that should be answered before Jenny can pick this up.

@seipeljl
Copy link

seipeljl commented Dec 5, 2024

@jquispe-oddball @Kate-allbee @candilemoine @nihil2501 We are going with Completed for the second tab name.

@jquispe-oddball
Copy link

Submitted pr

@candilemoine candilemoine added engineering Engineering topics and removed arf-eng labels Dec 18, 2024
@Kate-allbee
Copy link
Contributor

Kate-allbee commented Jan 16, 2025

@jquispe-oddball One thing I noticed in staging is:
Image
Pending requests can just say "Pending"

Talked with @seipeljl and She is going to provide content updates in a separate ticket

@Kate-allbee
Copy link
Contributor

Kate-allbee commented Jan 16, 2025

@jquispe-oddball Not sure if this is in another ticket, so disregard if so!
Noticed that the colors are missing from the Accepted and Declined tags in the completed tab.

Image

Image

@jquispe-oddball
Copy link

@Kate-allbee yes, it's in another ticket and marked for V1
#98941

@Kate-allbee
Copy link
Contributor

@jquispe-oddball Looking at the mobile responsiveness of the tabs design and it looks like when the window is resized from desktop to mobile the tabs jump to stretch the span of the window at a certain point.
The way the component is built is that the tabs should be the same size in mobile/tablet/desktop. 320px x 50px:

Image

Desk:

Image

Tablet resize:

Image

Mobile:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accredited-rep-facing Accredited Representative Facing Team engineering Engineering topics frontend
Projects
None yet
Development

No branches or pull requests

6 participants