[Art/96894] - poa search tabs #33602
Conversation
There was a problem hiding this comment.
Icon found
Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.
What you can do
Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.
Note:
Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon
| {poaRequest.status === 'Pending' && ( | ||
| <> | ||
| {expiresSoon(poaRequest.expiresAt) && ( | ||
| <va-icon |
va-vfs-bot
temporarily deployed
to
master/art/96894/poa-search-tabs/main
va-vfs-bot
temporarily deployed
to
master/art/96894/poa-search-tabs/main
nihil2501
added
the
benefits-accredited-rep-facing
There was a problem hiding this comment.
- No results doesn't mean that tabs shouldn't render. They ought to be able to try a new query (change tab)
NavLinkAPIaria-selected?- When building off another branch, branch off of it and open a PR into the branch you are branching off of:
branch 1 <- branch 2
From the video, it seems like there are font regressions in multiple areas?
src/applications/accredited-representative-portal/containers/POARequestsPage.jsx
Outdated
Show resolved
Hide resolved
src/applications/accredited-representative-portal/containers/POARequestsPage.jsx
Outdated
Show resolved
Hide resolved
src/applications/accredited-representative-portal/containers/POARequestsPage.jsx
Outdated
Show resolved
Hide resolved
src/applications/accredited-representative-portal/containers/POARequestsPage.jsx
Outdated
Show resolved
Hide resolved
jquispe-oddball
force-pushed
the
art/96894/poa-search-tabs
branch
from
d4b5ad4 to
6291cc3
Compare
va-vfs-bot
temporarily deployed
to
master/art/96894/poa-search-tabs/main
jquispe-oddball
force-pushed
the
art/96894/poa-search-tabs
branch
from
e5ff11b to
3e931a4
Compare
va-vfs-bot
temporarily deployed
to
master/art/96894/poa-search-tabs/main
va-vfs-bot
temporarily deployed
to
master/art/96894/poa-search-tabs/main
jquispe-oddball
force-pushed
the
art/96894/poa-search-tabs
branch
from
00846d3 to
08a41b4
Compare
va-vfs-bot
temporarily deployed
to
master/art/96894/poa-search-tabs/main
jquispe-oddball
force-pushed
the
art/96894/poa-search-tabs
branch
from
03ecc2b to
6aa9833
Compare
va-vfs-bot
temporarily deployed
to
master/art/96894/poa-search-tabs/main
jquispe-oddball
force-pushed
the
art/96894/poa-search-tabs
branch
from
7bf54af to
69cb04a
Compare
va-vfs-bot
temporarily deployed
to
master/art/96894/poa-search-tabs/main
jquispe-oddball
force-pushed
the
art/96894/poa-search-tabs
branch
from
69cb04a to
7d113ca
Compare
va-vfs-bot
temporarily deployed
to
master/art/96894/poa-search-tabs/main
Query params are not the same sort of thing as path segments in `react-router` and `NavLink` won't understand them in the same way.
There was a problem hiding this comment.
Icon found
Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.
What you can do
Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.
Note:
Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon
| {poaRequest.status === 'Pending' && ( | ||
| <> | ||
| {expiresSoon(poaRequest.expiresAt) && ( | ||
| <va-icon |
va-vfs-bot
temporarily deployed
to
master/art/96894/poa-search-tabs/main
There was a problem hiding this comment.
Icon found
Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.
What you can do
Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.
Note:
Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon
| {poaRequest.status === 'Pending' && ( | ||
| <> | ||
| {expiresSoon(poaRequest.expiresAt) && ( | ||
| <va-icon |
va-vfs-bot
temporarily deployed
to
master/art/96894/poa-search-tabs/main
nihil2501
force-pushed
the
art/96894/poa-search-tabs
branch
from
71f8790 to
1f7a83e
Compare
va-vfs-bot
temporarily deployed
to
master/art/96894/poa-search-tabs/main
Adding tabs to the POA Requests page, see existing ticket .
Merged in existing PR to get tabs to work with loaders.
Some notes:
Screen.Recording.2024-12-16.at.3.34.46.PM.mov