Update a lot of test env gems (#3797)

* Update rspec gems
* Update rubocop gems and rerun _todo file
* Update guard
* Update webmock gem
* Manually fix some exclusions for RSpec/SubjectStub

.rubocop.yml

@@ -309,13 +309,15 @@ RSpec/ScatteredLet:
 # Might be worth revisiting at some point
 RSpec/SubjectStub:
   Exclude:
+    - 'modules/vaos/spec/services/user_service_spec.rb'
     - 'spec/jobs/education_form/create_daily_spool_files_spec.rb'
     - 'spec/jobs/education_form/forms/va1990_spec.rb'
     - 'spec/jobs/transactional_email_analytics_job_spec.rb'
     - 'spec/lib/bb/generate_report_request_form_spec.rb'
     - 'spec/lib/common/models/redis_store_spec.rb'
     - 'spec/lib/evss/disability_compensation_form/data_translation_all_claim_spec.rb'
     - 'spec/lib/evss/disability_compensation_form/data_translation_spec.rb'
+    - 'spec/lib/mvi/service_spec.rb'
     - 'spec/lib/saml/health_status_spec.rb'
     - 'spec/lib/sm/client/folders_spec.rb'
     - 'spec/models/emis_redis/military_information_spec.rb'

.rubocop_todo.yml

@@ -1,11 +1,61 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-11-29 12:01:22 -0500 using RuboCop version 0.74.0.
+# on 2020-01-16 15:49:25 -0500 using RuboCop version 0.79.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 126
+# Cop supports --auto-correct.
+FactoryBot/FactoryClassName:
+  Enabled: false
+
+# Offense count: 31
+# Cop supports --auto-correct.
+RSpec/ContextMethod:
+  Exclude:
+    - 'spec/controllers/application_controller_spec.rb'
+    - 'spec/jobs/education_form/create_daily_spool_files_spec.rb'
+    - 'spec/jobs/education_form/forms/base_spec.rb'
+    - 'spec/jobs/education_form/forms/va0993_spec.rb'
+    - 'spec/jobs/education_form/forms/va1990_spec.rb'
+    - 'spec/jobs/education_form/forms/va1995_spec.rb'
+    - 'spec/jobs/education_form/forms/va1995s_spec.rb'
+    - 'spec/lib/common/client/configuration/base_spec.rb'
+    - 'spec/lib/pension_burial/processing_office_spec.rb'
+    - 'spec/models/mhv_account_spec.rb'
+    - 'spec/request/address_request_spec.rb'
+    - 'spec/request/evss_claims_async_spec.rb'
+    - 'spec/routing/address_routing.rb'
+    - 'spec/services/users/profile_spec.rb'
+
+# Offense count: 69
+# Cop supports --auto-correct.
+# Configuration parameters: AllowConsecutiveOneLiners.
+RSpec/EmptyLineAfterExample:
+  Enabled: false
+
+# Offense count: 14
+RSpec/SubjectStub:
+  Exclude:
+    - 'spec/jobs/education_form/create_daily_spool_files_spec.rb'
+    - 'spec/jobs/education_form/forms/va1990_spec.rb'
+    - 'spec/jobs/transactional_email_analytics_job_spec.rb'
+    - 'spec/lib/bb/generate_report_request_form_spec.rb'
+    - 'spec/lib/common/models/redis_store_spec.rb'
+    - 'spec/lib/evss/disability_compensation_form/data_translation_all_claim_spec.rb'
+    - 'spec/lib/evss/disability_compensation_form/data_translation_spec.rb'
+    - 'spec/lib/saml/health_status_spec.rb'
+    - 'spec/lib/sm/client/folders_spec.rb'
+    - 'spec/models/emis_redis/military_information_spec.rb'
+    - 'spec/models/session_spec.rb'
+    - 'spec/services/evss_claim_service_spec.rb'
+    - 'spec/services/mhv_accounts_service_spec.rb'
+    - 'spec/uploaders/evss_claim_document_uploader_spec.rb'
+    - 'modules/vaos/spec/services/user_service_spec.rb'
+    - 'spec/lib/mvi/service_spec.rb'
+
 # Offense count: 7
 ThreadSafety/ClassAndModuleAttributes:
   Exclude:
@@ -17,7 +67,7 @@ ThreadSafety/ClassAndModuleAttributes:
     - 'lib/facilities/vha_facility.rb'
     - 'lib/saml/health_status.rb'
 
-# Offense count: 36
+# Offense count: 42
 ThreadSafety/InstanceVariableInClassMethod:
   Exclude:
     - 'app/models/base_facility.rb'

Gemfile.lock

@@ -339,7 +339,7 @@ GEM
     fast_jsonapi (1.5)
       activesupport (>= 4.2)
     fastimage (2.1.7)
-    ffi (1.11.3)
+    ffi (1.12.1)
     figaro (1.1.1)
       thor (~> 0.14)
     flipper (0.17.1)
@@ -370,7 +370,7 @@ GEM
       faraday
       faraday_middleware
       mime-types
-    guard (2.15.1)
+    guard (2.16.1)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (>= 1.0.12, < 2.0)
@@ -426,14 +426,13 @@ GEM
     levenshtein-ffi (1.1.0)
       ffi (~> 1.9)
     liquid (4.0.3)
-    listen (3.1.5)
-      rb-fsevent (~> 0.9, >= 0.9.4)
-      rb-inotify (~> 0.9, >= 0.9.7)
-      ruby_dep (~> 1.2)
+    listen (3.2.1)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
     loofah (2.4.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
-    lumberjack (1.0.13)
+    lumberjack (1.1.1)
     mail (2.7.1)
       mini_mime (>= 0.1.1)
     marcel (0.3.3)
@@ -481,7 +480,7 @@ GEM
       activerecord (>= 4.2)
       request_store (~> 1.1)
     parallel (1.19.1)
-    parser (2.7.0.0)
+    parser (2.7.0.2)
       ast (~> 2.4.0)
     pdf-core (0.7.0)
     pdf-forms (1.2.0)
@@ -505,7 +504,7 @@ GEM
     pry-byebug (3.7.0)
       byebug (~> 11.0)
       pry (~> 0.10)
-    public_suffix (4.0.2)
+    public_suffix (4.0.3)
     puma (4.3.1)
       nio4r (~> 2.0)
     puma-plugin-statsd (0.1.0)
@@ -557,7 +556,7 @@ GEM
     rainbow (3.0.0)
     rake (13.0.1)
     rb-fsevent (0.10.3)
-    rb-inotify (0.10.0)
+    rb-inotify (0.10.1)
       ffi (~> 1.0)
     redis (3.3.5)
     redis-namespace (1.7.0)
@@ -580,12 +579,12 @@ GEM
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
       rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.0)
-      rspec-support (~> 3.9.0)
+    rspec-core (3.9.1)
+      rspec-support (~> 3.9.1)
     rspec-expectations (3.9.0)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.0)
+    rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-rails (3.9.0)
@@ -596,29 +595,28 @@ GEM
       rspec-expectations (~> 3.9.0)
       rspec-mocks (~> 3.9.0)
       rspec-support (~> 3.9.0)
-    rspec-support (3.9.0)
+    rspec-support (3.9.2)
     rspec_junit_formatter (0.4.1)
       rspec-core (>= 2, < 4, != 2.12.0)
-    rubocop (0.78.0)
+    rubocop (0.79.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
-      parser (>= 2.6)
+      parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 1.7)
     rubocop-junit-formatter (0.1.4)
     rubocop-rails (2.4.1)
       rack (>= 1.1)
       rubocop (>= 0.72.0)
-    rubocop-rspec (1.35.0)
-      rubocop (>= 0.60.0)
+    rubocop-rspec (1.37.1)
+      rubocop (>= 0.68.1)
     rubocop-thread_safety (0.3.4)
       rubocop (>= 0.51.0)
     ruby-progressbar (1.10.1)
     ruby-rc4 (0.1.5)
     ruby-saml (1.11.0)
       nokogiri (>= 1.5.10)
-    ruby_dep (1.5.0)
     rubyzip (2.0.0)
     rufus-scheduler (3.6.0)
       fugit (~> 1.1, >= 1.1.6)
@@ -697,7 +695,7 @@ GEM
       ethon (>= 0.9.0)
     tzinfo (1.2.6)
       thread_safe (~> 0.1)
-    unicode-display_width (1.6.0)
+    unicode-display_width (1.6.1)
     upsert (2.2.1)
     uri_template (0.7.0)
     utf8-cleaner (0.2.5)
@@ -716,7 +714,7 @@ GEM
       activemodel (>= 5.0)
       bindex (>= 0.4.0)
       railties (>= 5.0)
-    webmock (3.7.6)
+    webmock (3.8.0)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)