Bugfix: NoSuchKey error (#3746)

department-of-veterans-affairs/va.gov-team#4633
department-of-veterans-affairs · Jan 8, 2020 · d8e0826 · d8e0826
1 parent aefee4d
commit d8e0826
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/app/controllers/concerns/form_attachment_create.rb b/app/controllers/concerns/form_attachment_create.rb
@@ -11,10 +11,9 @@ def create
     form_attachment_model = self.class::FORM_ATTACHMENT_MODEL
     form_attachment = form_attachment_model.new
     namespace = form_attachment_model.to_s.underscore.split('/').last
+    filtered_params = params.require(namespace).permit(:file_data)
 
-    file_data = params.require(namespace).permit(:file_data)
-
-    form_attachment.set_file_data!(file_data)
+    form_attachment.set_file_data!(filtered_params[:file_data])
     form_attachment.save!
     render(json: form_attachment)
   end

diff --git a/spec/controllers/v0/hca_attachments_controller_spec.rb b/spec/controllers/v0/hca_attachments_controller_spec.rb
@@ -8,8 +8,9 @@
       post(:create, params: { hca_attachment: {
              file_data: fixture_file_upload('pdf_fill/extras.pdf')
            } })
-
-      expect(JSON.parse(response.body)['data']['attributes']['guid']).to eq HcaAttachment.last.guid
+      guid = JSON.parse(response.body)['data']['attributes']['guid']
+      expect(guid).to eq HcaAttachment.last.guid
+      expect(File).to exist("spec/support/uploads/hca_attachments/#{guid}")
     end
 
     it 'validates input parameters' do