Add stuck submissions to mailer (#3785)

* Add stuck submissions to mailer
move views to proper location
refactor table into partial

* Line too long

modules/vba_documents/app/mailers/vba_documents/unsuccessful_report_mailer.rb

@@ -13,12 +13,19 @@ class UnsuccessfulReportMailer < ApplicationMailer
       [email protected]
     ].freeze
 
-    def build(unsuccessful_submissions, date_from, date_to)
+    def build(unsuccessful_submissions, stuck_submissions, date_from, date_to)
       @unsuccessful_submissions = unsuccessful_submissions
+      @stuck_submissions = stuck_submissions
       @date_from = date_from
       @date_to = date_to
 
-      path = VBADocuments::Engine.root.join('app', 'mailers', 'vba_documents', 'views', 'unsuccessful_report.erb')
+      path = VBADocuments::Engine.root.join(
+        'app',
+        'views',
+        'vba_documents',
+        'unsuccessful_report_mailer',
+        'unsuccessful_report.html.erb'
+      )
       template = File.read(path)
 
       mail(

modules/vba_documents/app/mailers/vba_documents/views/unsuccessful_report.erb → modules/vba_documents/app/views/vba_documents/unsuccessful_report_mailer/_submission_table.html.erb

@@ -1,6 +1,3 @@
-<h1>Unsuccessful Submissions <%= 'Summary' if @date_to.monday? %> </h1>
-<hr />
-<h3>From <%= @date_from %> -- <%= @date_to %> </h3>
 <table>
   <thead>
     <tr>
@@ -14,7 +11,7 @@
     </tr>
   </thead>
   <tbody>
-    <% @unsuccessful_submissions.each do |submission| %>
+    <% submissions.each do |submission| %>
       <tr>
         <td><%= submission.guid %></td>
         <td><%= submission.consumer_name %></td>

modules/vba_documents/app/views/vba_documents/unsuccessful_report_mailer/unsuccessful_report.html.erb

@@ -0,0 +1,10 @@
+<h1>Unsuccessful Submissions <%= 'Summary' if @date_to.monday? %> </h1>
+<hr />
+<h3>From <%= @date_from %> -- <%= @date_to %> </h3>
+<h4> Unsuccessful count: <%= @unsuccessful_submissions.count %>
+<%= render partial: 'submission_table', locals: {submissions: @unsuccessful_submissions } %>
+
+<hr>
+
+<h4> Stuck Submissions Count: <%= @stuck_submissions.count %>
+<%= render partial: 'submission_table', locals: {submissions: @stuck_submissions} unless @stuck_submissions.count.zero? %>

modules/vba_documents/app/workers/vba_documents/report_unsuccessful_submissions.rb

@@ -10,11 +10,15 @@ def perform
       if Settings.vba_documents.unsuccessful_report_enabled
         to = Time.zone.now
         from = to.monday? ? 7.days.ago : 1.day.ago
-        submissions = VBADocuments::UploadSubmission.where(
+        errored_submissions = VBADocuments::UploadSubmission.where(
           created_at: from..to,
           status: %w[error expired]
         )
-        VBADocuments::UnsuccessfulReportMailer.build(submissions, from, to).deliver_now
+        stuck_submissions = VBADocuments::UploadSubmission.where(
+          created_at: from..to,
+          status: 'uploaded'
+        )
+        VBADocuments::UnsuccessfulReportMailer.build(errored_submissions, stuck_submissions, from, to).deliver_now
       end
     end
   end

modules/vba_documents/spec/jobs/report_unsuccessful_submissions_spec.rb

@@ -17,6 +17,10 @@
             created_at: from..to,
             status: %w[error expired]
           ),
+          VBADocuments::UploadSubmission.where(
+            created_at: from..to,
+            status: 'uploaded'
+          ),
           from,
           to
         ).and_return(double.tap do |mailer|

modules/vba_documents/spec/mailers/unsuccessful_report_mailer_spec.rb

@@ -4,10 +4,11 @@
 
 RSpec.describe VBADocuments::UnsuccessfulReportMailer, type: [:mailer] do
   let(:error_upload) { FactoryBot.create(:upload_submission, :status_error) }
+  let(:uploaded_upload) { FactoryBot.create(:upload_submission, :status_uploaded) }
 
   describe '#build' do
     subject do
-      described_class.build([error_upload], 7.days.ago, Time.zone.now).deliver_now
+      described_class.build([error_upload], [uploaded_upload], 7.days.ago, Time.zone.now).deliver_now
     end
 
     it 'sends the email' do