Dont actually healthcheck vbms and bgs yet (#3665)

* merge conflict

* Dont actually use bgs and vbms healthchecks yet

* update the specs for bgs and vbms health check

* Doesnt make sense to track the health checker for coverage until vbms and bgs are live in prod

modules/claims_api/lib/claims_api/health_checker.rb

@@ -18,13 +18,17 @@ def self.mvi_is_healthy?
     end
 
     def self.bgs_is_healthy?
-      response = Faraday.get(BGS_WSDL)
-      response.status == 200
+      # response = Faraday.get(BGS_WSDL)
+      # response.status == 200
+      # BGS does not have upper level access yet, just return true
+      true
     end
 
     def self.vbms_is_healthy?
-      response = Faraday.get(Settings.vbms.url)
-      response.status == 200
+      # response = Faraday.get(Settings.vbms.url)
+      # response.status == 200
+      # VBMS does not have upper level access yet, just return true
+      true
     end
   end
 end

modules/claims_api/spec/lib/health_checker_spec.rb

@@ -33,15 +33,19 @@
       allow(ClaimsApi::HealthChecker).to receive(:bgs_is_healthy?).and_return(true)
       allow(ClaimsApi::HealthChecker).to receive(:evss_is_healthy?).and_return(true)
       allow(ClaimsApi::HealthChecker).to receive(:mvi_is_healthy?).and_return(true)
-      allow(Faraday).to receive(:get).and_return(OpenStruct.new(status: 503))
+      # VBMS does not have upper level access yet, just return true
+      # allow(Faraday).to receive(:get).and_return(OpenStruct.new(status: 503))
+      allow(ClaimsApi::HealthChecker).to receive(:vbms_is_healthy?).and_return(false)
       expect(ClaimsApi::HealthChecker.services_are_healthy?).to eq(false)
     end
 
     it 'returns correct status when bgs is not healthy' do
       allow(ClaimsApi::HealthChecker).to receive(:evss_is_healthy?).and_return(true)
       allow(ClaimsApi::HealthChecker).to receive(:mvi_is_healthy?).and_return(true)
       allow(ClaimsApi::HealthChecker).to receive(:vbms_is_healthy?).and_return(true)
-      allow(Faraday).to receive(:get).and_return(OpenStruct.new(status: 503))
+      # BGS does not have upper level access yet, just return true
+      # allow(Faraday).to receive(:get).and_return(OpenStruct.new(status: 503))
+      allow(ClaimsApi::HealthChecker).to receive(:bgs_is_healthy?).and_return(false)
       expect(ClaimsApi::HealthChecker.services_are_healthy?).to eq(false)
     end
   end

spec/spec_helper.rb

@@ -35,6 +35,7 @@
     add_filter 'lib/vet360/response.rb'
     add_filter 'modules/claims_api/app/controllers/claims_api/v0/forms/disability_compensation_controller.rb'
     add_filter 'modules/claims_api/app/controllers/claims_api/v1/forms/disability_compensation_controller.rb'
+    add_filter 'modules/claims_api/lib/claims_api/health_checker.rb'
     add_filter 'modules/va_facilities/lib/va_facilities/engine.rb'
     add_filter 'version.rb'