-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CST] Override 'PMR Pending' tracked items to all have the status 'NEED_FROM_OTHERS' #19168
Conversation
All set, thank you! Good morning as well. |
Backend-review-group approval confirmed. |
…ED_FROM_OTHERS' (#19168) * [CST] Override 'PMR Pending' tracked items to all have the status 'NEEDED_FROM_OTHERS' * Removes trailing whitespace * Rubocop fixes * Fixes failing spec that caught my syntax issue. * Rubocop trailing whitespace * Fixes another spec. Good spec. * Fixes typos in CODEOWNERS file * Adds a spec for Lighthouse service to confirm status override * Rubocop single quote
…ED_FROM_OTHERS' (#19168) * [CST] Override 'PMR Pending' tracked items to all have the status 'NEEDED_FROM_OTHERS' * Removes trailing whitespace * Rubocop fixes * Fixes failing spec that caught my syntax issue. * Rubocop trailing whitespace * Fixes another spec. Good spec. * Fixes typos in CODEOWNERS file * Adds a spec for Lighthouse service to confirm status override * Rubocop single quote
Summary
displayName
of"PMR Pending"
will now all have theirstatus
fields reported asNEEDED_FROM_OTHERS
to the web and mobile clients.Related issue(s)
Testing done
NEEDED_FROM_YOU
even though the veteran does not have an action to take.Screenshots
What areas of the site does it impact?
Mobile and web client, the veteran's view of their actionable items.
Acceptance criteria
Requested Feedback
What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?
This is my first issue, so I am interested in feedback around
claims_api/.../swagger.json
as my source for what the response will actually look like, but if that's inaccurate, this code will not work. How can I make sure I definitely, for certain, know what the json schema I am modifying looks like?