Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CST] Override 'PMR Pending' tracked items to all have the status 'NEED_FROM_OTHERS' #19168

Merged
merged 15 commits into from
Nov 6, 2024

Conversation

iandonovan
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): NO
  • TrackedItems within Claims with the displayName of "PMR Pending" will now all have their status fields reported as NEEDED_FROM_OTHERS to the web and mobile clients.
  • There is a request out to BGS to recategorize these Items even further upstream, but that could take months. This is a unified workaround to consolidate code in an area where both the web and mobile clients retrieve it.
  • Benefits Management 2

Related issue(s)

Testing done

  • New code is covered by unit tests
  • PMR Pending tracked items were incorrectly reported as NEEDED_FROM_YOU even though the veteran does not have an action to take.
  • PMR Pending tracked items will be in a new section on the website and mobile app.

Screenshots

What areas of the site does it impact?

Mobile and web client, the veteran's view of their actionable items.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

This is my first issue, so I am interested in feedback around

  1. Code style
  2. How I should work with this sort of ticket going forward. I used claims_api/.../swagger.json as my source for what the response will actually look like, but if that's inaccurate, this code will not work. How can I make sure I definitely, for certain, know what the json schema I am modifying looks like?

@iandonovan
Copy link
Contributor Author

@iandonovan Can you add or update any testing in spec/lib/lighthouse/benefits_claims/service_spec.rb?
Can you also update this line in the CODEOWNERS file to fix the typo? it needs an s after benefit. I was wondering why backend-review-group was the only codeowner!! 😄

Sure thing!
Should I do the same to the line beneath it (931), since that has the same typo? benefit_claims --> benefits_claims.

Yes, please! good catch

All set, thank you! Good morning as well.

@va-vfs-bot va-vfs-bot temporarily deployed to 19152-pmr-status-override/main/main October 31, 2024 17:06 Inactive
Copy link

Backend-review-group approval confirmed.

@iandonovan iandonovan merged commit 5f7ecc7 into master Nov 6, 2024
23 of 24 checks passed
@iandonovan iandonovan deleted the 19152-pmr-status-override branch November 6, 2024 16:40
SamStuckey pushed a commit that referenced this pull request Nov 7, 2024
…ED_FROM_OTHERS' (#19168)

* [CST] Override 'PMR Pending' tracked items to all have the status 'NEEDED_FROM_OTHERS'

* Removes trailing whitespace

* Rubocop fixes

* Fixes failing spec that caught my syntax issue.

* Rubocop trailing whitespace

* Fixes another spec. Good spec.

* Fixes typos in CODEOWNERS file

* Adds a spec for Lighthouse service to confirm status override

* Rubocop single quote
pennja pushed a commit that referenced this pull request Nov 8, 2024
…ED_FROM_OTHERS' (#19168)

* [CST] Override 'PMR Pending' tracked items to all have the status 'NEEDED_FROM_OTHERS'

* Removes trailing whitespace

* Rubocop fixes

* Fixes failing spec that caught my syntax issue.

* Rubocop trailing whitespace

* Fixes another spec. Good spec.

* Fixes typos in CODEOWNERS file

* Adds a spec for Lighthouse service to confirm status override

* Rubocop single quote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants