Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CST]: Similarly overrides PMR Pending displayName to be human-readable Private Medical Record #19319

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

iandonovan
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): NO
  • TrackedItems within Claims with the displayName of "PMR Pending" will now all have their displayName fields reported as Private Medical Record to the web and mobile clients.
  • There is a request out to BGS to recategorize these Items even further upstream, but that could take months. This is a unified workaround to consolidate code in an area where both the web and mobile clients retrieve it.
  • Benefits Management 2

Related issue(s)

Testing done

  • New code is covered by unit tests
  • PMR Pending tracked items were reported as PMR PENDING and we'd like to have that be more human-readable.
  • The frontend is already overriding this on its own, and this change will move that mapping further upstream so it can be seamlessly mirrored on the mobile app.

Screenshots

What areas of the site does it impact?

Mobile and web client, the veteran's view of their actionable items.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@iandonovan
Copy link
Contributor Author

@department-of-veterans-affairs/backend-review-group Anyone know what this test failure might be about?

Copy link

Backend-review-group approval confirmed.

@rmtolmach
Copy link
Contributor

I'm covering for support for a couple days, so I'm not sure if you were hitting a known bug in master. But it didn't look like it could be related to your code and it's passing now, so 👍

@iandonovan iandonovan merged commit 210687d into master Nov 12, 2024
43 of 44 checks passed
@iandonovan iandonovan deleted the 96081-pmr-display-name branch November 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants