-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile: Merge appointment filterer logic and update timezone window #19843
Open
Tonksthebear
wants to merge
6
commits into
master
Choose a base branch
from
mobile-appointments-presentation-filter-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@simiadebowale Do you have any concerns with me removing the flipper? For mobile, it was always flipped on so for us it made no difference. Just want to confirm web would be ok with the presentation filterer always being used as well |
va-vfs-bot
temporarily deployed
to
mobile-appointments-presentation-filter-fix/main/main
December 11, 2024 19:54
Inactive
va-vfs-bot
temporarily deployed
to
mobile-appointments-presentation-filter-fix/main/main
December 12, 2024 18:43
Inactive
va-vfs-bot
temporarily deployed
to
mobile-appointments-presentation-filter-fix/main/main
December 12, 2024 19:02
Inactive
va-vfs-bot
temporarily deployed
to
mobile-appointments-presentation-filter-fix/main/main
December 12, 2024 19:59
Inactive
va-vfs-bot
temporarily deployed
to
mobile-appointments-presentation-filter-fix/main/main
December 13, 2024 19:27
Inactive
jperk51
approved these changes
Dec 16, 2024
simiadebowale
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ericboehs
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reduce duplicate code between mobile and appointment service. Increases window when determining appointment validity in order to compensate for timezone differences.
Related issue(s)
department-of-veterans-affairs/va-mobile-app#10320
Testing done
Existing tests cover the changes except one was testing functionality when flipper was off
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?