Rm replace signinmodal (#32807)

* refactor to va-modal * updates css + fix unit tests * remove VaModal check unit test * updates for e2e fixes * attempt #2 for e2e bypass * update selector for h1 * update selector in cypress test * add atrribute to selector * will only render if visible is true * adjust cypress tests in platform/user and applicatiosn/dhp-connected-devices * fix selector in unauthed-flows cypress test; clean up unsued code * console log to see what happens in ci Signed-off-by: Micah Chiang <[email protected]> * more info Signed-off-by: Micah Chiang <[email protected]> * explicitly set visible to false first Signed-off-by: Micah Chiang <[email protected]> * remove console logs Signed-off-by: Micah Chiang <[email protected]> * comment out analytics tests Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Alexander Garcia <[email protected]> Co-authored-by: Alexander Garcia <[email protected]> Co-authored-by: Micah Chiang <[email protected]>
department-of-veterans-affairs · Nov 20, 2024 · 840cf5c · 840cf5c
1 parent 886f956
commit 840cf5c
Show file tree

Hide file tree

Showing 12 changed files with 172 additions and 381 deletions.
diff --git a/src/applications/dhp-connected-devices/tests/dhp-consent-flow.cypress.spec.js b/src/applications/dhp-connected-devices/tests/dhp-consent-flow.cypress.spec.js
@@ -37,7 +37,10 @@ describe(manifest.appName, () => {
     cy.get('#signin-signup-modal').should('be.visible');
     cy.axeCheck();
 
-    cy.get('#signin-signup-modal .va-modal-close').click();
+    cy.get('#signin-signup-modal')
+      .shadow()
+      .find('.va-modal-close')
+      .click();
     cy.get('#signin-signup-modal').should('not.exist');
   });
 });
diff --git a/src/applications/disability-benefits/all-claims/tests/all-claims-wizard.cypress.spec.js b/src/applications/disability-benefits/all-claims/tests/all-claims-wizard.cypress.spec.js
@@ -71,7 +71,10 @@ describe('526 wizard', () => {
 
   it('should show the form wizard', () => {
     cy.url().should('include', `${DISABILITY_526_V2_ROOT_URL}/start`);
-    cy.get('h1').should('have.text', 'File for disability compensation');
+    cy.get('h1[data-testid="form-title"]').should(
+      'have.text',
+      'File for disability compensation',
+    );
     cy.axeCheck();
   });
 
@@ -121,7 +124,7 @@ describe('526 wizard', () => {
     const h1Text = 'File for disability compensation';
     // starts with focus on breadcrumb
     // cy.get('va-breadcrumbs').first().should('have.focus'); // not working?
-    cy.get('h1').should('have.text', h1Text);
+    cy.get('h1[data-testid="form-title"]').should('have.text', h1Text);
 
     cy.get('va-radio-option[value="appeals"]').click(checkOpt);
     cy.checkFormChange({
@@ -147,7 +150,10 @@ describe('526 wizard', () => {
       .first()
       .click();
     // title changes & gets focus
-    cy.get('h1').should('have.text', h1Text + h1Addition);
+    cy.get('h1[data-testid="form-title"]').should(
+      'have.text',
+      h1Text + h1Addition,
+    );
     cy.focused().should('have.text', h1Text + h1Addition);
     cy.checkStorage(WIZARD_STATUS, 'complete');
     cy.location('pathname').should(